From: Diego Z. <za...@ce...> - 2001-01-29 14:31:12
|
> OK, if we're going to use hidden files then I think we should change > AppRun too, eg: > > .DirIcon.png and .AppRun > > The old files will still be supported for compatibility for a while... No, I don't think we should change AppRun. An application directory is defined by the application, and as such it should be clearly visible. AppRun is the main thing in an application directory. I'm OK with using .AppIcon (or .DirIcon) on application directories, although I don't think it's so critical to hide the application icon as it is to hide regular directory icon files. > Maybe we should add a '[2 hidden files]' message to the toolbar when you > open the directory? That sounds good to me. > Is '~' allowed in globicons? Not by default. But it wouldn't be too difficult to replace ~ with the value of HOME while reading globicons. > - You don't need to check the size of globicons icons, since they always > come from a trusted source. OK. > - Maybe we should merge all the globicon lists in Choices? But then, how > do we let a user disable a sysadmin's choice? Hm... merging the lists sounds like a good thing, but the point about disabling sysadmin choices is also valid. How about: - Later entries override earlier ones - We define a globicon entry without an icon to mean "no icon for this file", so to remove a sysadmin choice, the user either sets a different icon, or creates a globicon entry with an empty icon path. This would complicate the maintenance of the globicons file a little bit: when the user clicks on "remove custom icon", how do we know whether to simply remove the entry or replace it with an "empty" one? > - Much of the patch could be moved to a new file? Yes. > - Closing the Set Icon dialog says: > Gtk-CRITICAL **: file gtkwidget.c: line 1385 (gtk_widget_destroy): > assertion `GTK_IS_WIDGET (widget)' failed. Hm... I don't get that error, no matter how I close the dialog. I'm pretty sure I had it at some point, and had something to do with how destroying the dialog is handled. I set a handler for the "destroy" signal in icon_set_handler_dialog(), which calls the close_icon_dialog() function. Maybe somewhere in there? > It's a fun patch, though, so I guess it will go in soon ;-) Great! :-) Let me know if you want me to take care of any of the changes discussed above. However, I won't have much time to devote to it in the near future, unfortunately... :-( --Diego |