Re: [rox-devel] Easier panel management (git update)

[Thomas L. <ta...@gm...>]

On 22/09/2007, Tony Houghton <h...@re...> wrote:
> I've made it possible to add and remove panels from ROX's menus (Add
> Panel is in the pinboard menu and Remove Panel is in the panel menu). I
> chose to do it this way rather than with a separate applet because of
> some implementation difficulties I envisaged in the latter.

This looks like a good idea. Some minor issues ;-)

- When a new panel is added, 'panels' is saved but the panel itself
isn't. When you restart, the side information is therefore missing.

- Why does icon_prepare_menu take the stock icons as parameters? Could
the caller set the icon on the menu item itself?

- save_panels isn't atomic (a crash while saving might corrupt the
'panels' file). Probably not very important, but I think everything
else uses rename() to avoid problems.

Thanks!


-- 
Dr Thomas Leonard		http://rox.sourceforge.net
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1