Re: [rox-devel] icons on panel not getting updated

[Thomas L. <ta...@gm...>]

On 6/23/06, Dennis Tomas <2t...@in...> wrote:
> Dennis Tomas wrote:
> > A little problem I experienced with apps that change their icon (like
> > Trashcan):
> > When the .DirIcon or the globicon-entry of a panel-item is changed, the
> > icon on the panel will still be the old one.
> >
> Here is a patch that fixes it by introducing a new function
> panel_update_icon(const gchar* path), which is called by examine().

Here's a shorter patch that should do the same thing (also committed to svn).

The cause was the panel scaling code: since panel icons can now be any
size (not just small/large/huge), the panel keeps a scaled copy of the
original icon used by the rest of the filer. This copy wasn't getting
updated, so icons didn't update even though they got the 'redraw'
signal at the right time.

I also noticed another bug while looking at this one: now that MIME
icons come from the GTK icon system they weren't getting cached. This
caused it to send a 'redraw' signal every time the mouse moved over a
panel icon! I've changed it to just get the pathname from GTK, but use
the ROX-Filer cache to actually load it.

Does this patch fix it for you?


-- 
Dr Thomas Leonard		http://rox.sourceforge.net
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1