Re: [rox-users] DevTray steals icons

[Thomas L. <ta...@gm...>]

On 8/27/07, Dennis Tomas <de...@gm...> wrote:
> Abrolag wrote:
> > I have my / directory showing on the task bar with a nice little hard
> > drive icon, but when I run devtray it kicks my preferred icon off and
> > puts one there I don't like at all, how can I stop this?
> >
> DevTray 0.3 passes an additional "AppID" argument to ROX-Filer's
> Set/UnsetIcon RPCs. This argument contains the unique ID of the app that
> set the icon. If an app gives its ID as argument, the icon is only
> (un)set if the ID matches the one found in the globicons entry. You need
> to use ROX-Filer from my repo to make this work:
> git://repo.or.cz/rox-filer/dt.git

This seems a bit complicated. Don't we just need to flag whether the
icon was set by the user or by a program?

Another possibility would be to have DevTray allow user configuration
of the device icons, since they're dynamic.

Review notes:
- It needs some documentation (in Manual.xml).
- What's this strdup for?
+		icon = g_hash_table_lookup(glob_icons, g_strdup(path));

I can't actually test it at the moment, though, as DevTray doesn't start for me:

Traceback (most recent call last):
  File "/var/cache/0install.net/implementations/sha1new=0e0175d993e3035d8b97566ab03a54b1b75e6d94/DevTray/AppletRun",
line 108, in <module>
    main_window.show()
  File "/var/cache/0install.net/implementations/sha1new=e6717a0bf4c1fa1ebe253ef48aacdfae7f94ad3b/python/traylib/tray_container.py",
line 70, in __size_allocate
    *self.__tray_args)
  File "/var/cache/0install.net/implementations/sha1new=0e0175d993e3035d8b97566ab03a54b1b75e6d94/DevTray/devtray.py",
line 22, in __init__
    self.__handlers = self.__import_handlers()
  File "/var/cache/0install.net/implementations/sha1new=0e0175d993e3035d8b97566ab03a54b1b75e6d94/DevTray/devtray.py",
line 227, in __import_handlers
    os.path.join(path, handler_name, '__init__.py'))
  File "/var/cache/0install.net/implementations/sha1new=0e0175d993e3035d8b97566ab03a54b1b75e6d94/DevTray/Handlers/Printer/__init__.py",
line 16, in <module>
    import printer_ui
  File "/var/cache/0install.net/implementations/sha1new=0e0175d993e3035d8b97566ab03a54b1b75e6d94/DevTray/Handlers/Printer/printer_ui.py",
line 223, in <module>
    conn = cups.Connection()
RuntimeError: httpConnectionEncrypt failed

I'm not running CUPS (I don't have a printer).


-- 
Dr Thomas Leonard		http://rox.sourceforge.net
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1