[rox-users] Re: corrupt thumbnail generation

[Brandin C. <cha...@ya...>]

--- Ken Hayber <ke...@ha...> wrote:

> Keith Warno wrote:
> > * <ke...@ha...> [17/01/2006 1417EST]:
> > 
> >>It would seem that the thumbnail code would have to detect when the
> >>image was opened for writing and defer creating the thumbnail until
> >>the file was closed.
> 
> >[...]
> 
> Hmm, another thought occurred to me.  If the file is being modified during
> the copy, then after it 
> is done, shouldn't the modified time be newer than the thumbnail creation
> time?  Shouldn't a refresh 
> pick this up and update the thumbnail?

I was curious and tested two methods of saving large images (from the
Internet) and noticing how ROX updates them: When I used Firefox to download
the image, I had a ROX-Filer window open and the thumbnail was only loaded
once (and was not updated when the copy finished). When I used touch on the
file, the thumbnail was reloaded automatically by ROX-Filer. I deleted the
file, then tried the transfer again with wget. As before, the thumbnail was
initially loaded for the file and showed nothing since it's initially an
incomplete file. But at the end of the transfer with wget, ROX-Filer reloaded
the thumbnail automatically, without my having to do anything.

The only difference I could see is in thw way wget updates the timestamps.
Firefox updates the mtime and ctime continuously during the transfer but then
didn't change it at the end of the transfer. Wget updates the mtime and ctime
continuously, but then at the end of the transfer wget seems to reset the
mtime to whatever the server reports. It looks like this final
timestamp-reset operation is what triggers the DNOTIFY event, but I can't be
sure of that.

I suppose the problem could be solved if ROX-Filer updated a file's thumbnail
if DN_MODIFY was detected on that file (or maybe the whole directory; I'm not
sure if dnotify can be used on individual files). To avoid updating too
often, ROX could defer updating the thumbnails if they had already been
updated in the last second or so.


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com