From: Jonatan L. <th...@ho...> - 2004-10-23 13:26:13
|
On Sat, 23 Oct 2004 12:25:28 +0000 Guido Schimmels <__g...@we...> wrote: > Am 22.10.2004 03:56:17 schrieb(en) Jonatan Liljedahl: > > On Thu, 21 Oct 2004 20:55:54 +0000 > > Guido Schimmels <__g...@we...> wrote: > > > > > > _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL > > > > _NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, > > > > _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_SHADE, > > > > _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE > > > > > > > > Shade, and minimize is there in the list but not on the > > titlebar. > > > > But maximize is missing... Anyhow, I would _very_much_ like an > > > > option for this becouse I actually don't want my apps to remove > > > > buttons from their titlebars! I _want_ to be able to minimize a > > > > dialogue window for > > > > example, etc... > > > > > > OroboROX 0.9.5 has a "Force Buttons" option now. > > > > Yes, very nice. > > > > > I've recompiled gtk with gcc-3.4.2 (was 3.3.3), and now Firefox > > > behaves like you say, before everything was fine ?!#?!? > > > > Lovely, isn't it? ;) > > Found the "source of entropy" :) > > This code is bogus: > > if ((c->size->flags & (PMinSize|PMaxSize)) && > c->size->min_width == c->size->max_width && > c->size->min_height == c->size->max_height) > > Must be: > > if ((c->size->flags & (PMinSize|PMaxSize)) > == (PMinSize|PMaxSize)) && > c->size->min_width == c->size->max_width && > c->size->min_height == c->size->max_height) > > That explains it all. > Either c->size->min_width or c->size->min_height > will be in random state at times. Therefore decoration will depend on > > the phase of the moon :) Ah, of course. It checked only for PMinSize OR PMaxSize. I didn't see that, but inserted a check for min!=0 instead (in my latest patch), so please ignore that and do your thing there. =) > That was my fault. > But there has been a variation on the theme in > clientToggleMaximized(), I'm not to blame for: > > if ((c->size->flags & (PMinSize | PMaxSize)) && > c->size->min_width == c->size->max_width && > c->size->min_height == c->size->max_height && > c->size->min_width != 0 && c->size->min_height != 0) But should this check be nessecary here? it's already done in get_allowed_actions() and clientToggleMaximized() checks for allowed action, right? > Nice try. Still bogus though... Hey, it worked, didn't it? ;) (Yes, I'm the one to blame for that) /Jonatan -=( http://kymatica.com )=- |