Re: [rox-devel] 3rd generation OroboROX Xinerama patch

[Jonatan L. <th...@ho...>]

On Tue, 22 Jun 2004 14:49:29 +0100
Tony Houghton <h...@re...> wrote:

> In <200...@ho...>, Jonatan Liljedahl wrote:
> 
> > On Mon, 21 Jun 2004 19:58:02 +0100
> > Tony Houghton <h...@re...> wrote:
> > 
> > > I've added those hotkeys for maximising across multiple monitors.
> > > I didn't give them default values because it's difficult to choose
> > > and they'll probably be rarely used. I hope you like my
> > > remodelling of the Keyboard settings GUI.
> > > 
> > > <http://www.realh.co.uk/unix.html#oroxine>.
> > >
> > 
> > Applied. Thanks.
> > BTW, I got a compile warning about uninitialized variable "bottom".
> > You might give it a look so nothing strange happens.
> 
> I don't understand how you spotted that amongst all the other warnings
> you get if you enable them!

=)
That was the only warning I got. But I didn't rebuild the entire
source...

> I'm pretty sure that's harmless - I added
> an extra switch statement that sets up these variables if they're
> going to be needed in the main switch - but I wonder why it doesn't
> warn about left, right and top too. Shall I add initialisers or just a
> comment along the lines of "never mind the warning"? I didn't bother
> with initialisers because it adds a teensy bit of bloat and the rest
> of the code isn't all that clean anyway.

Well, I haven't looked much on what that variable is used for. As long
as you can be sure that there's no risk for crashes or nasty bugs then
there's no problem with a warning message.. =)

Can you be sure that xinerama_screen_info[m] always is filled in, what
if you don't have Xinerama enabled? Or does it fill in the single screen
info in xinerama_screen_info[0] if Xinerama is not available? (And that
xineramaGetMonitorUnderPoint() works without Xinerama...)

I too wondered why it doesn't complain about left, right and top.

/Jonatan - [ http://kymatica.com ]