From: Stephen W. <st...@ke...> - 2003-11-29 17:44:52
|
Thomas Leonard <ta...@ec...> wrote: > On Sat, Nov 29, 2003 at 12:02:45PM +0000, Stephen Watson wrote: > > Thomas Leonard <ta...@ec...> wrote: > > > > > On Wed, Nov 26, 2003 at 09:32:34AM +0000, Stephen Watson wrote: > > > > gtksavebox.c needs to be using unescape_uri after get_local_path. > > > > Did we ever convert ROX-Lib's saving.py to escape URI's? It doesn't look > > like > > > > we did. > > > > > > I've converted get_local_path in ROX-Lib to always unescape. > > > > Currently doing the same to ROX-Filer, but trickier because you need to keep > > track of memory allocation. > > > > Noticed something. In run.c run_with_files() allocates argv via g_malloc, > > but I can't seem to find where it is g_free()'d. Can I assume it's a leak > > and go ahead and free it? > > Yes, thanks! We need to find a way to use valgrind's memory checker on the > filer, but GTK caches a load of stuff and makes it difficult to spot the > real leaks... I'm just about to commit the drag and drop fixes. get_local_path() now returns a string that needs to be freed and I think I've caught all the cases, but it may need double checking. Again valgrind would be useful. -- Stephen Watson http://www.kerofin.demon.co.uk/ I woke up and I had a big idea/To buy a new soul at the start of every year I paid up and it cost me pretty dear/Here's a hymn to those that disappear |