Re: [rox-devel] Re: ROX 2.1.0 - DnD saving not working

[Thomas L. <ta...@ec...>]

On Sat, Nov 29, 2003 at 12:02:45PM +0000, Stephen Watson wrote:
> Thomas Leonard <ta...@ec...> wrote:
> 
> > On Wed, Nov 26, 2003 at 09:32:34AM +0000, Stephen Watson wrote:
> > > gtksavebox.c needs to be using unescape_uri after get_local_path.
> > > Did we ever convert ROX-Lib's saving.py to escape URI's? It doesn't look
> like
> > > we did.
> > 
> > I've converted get_local_path in ROX-Lib to always unescape.
> 
> Currently doing the same to ROX-Filer, but trickier because you need to keep
> track of memory allocation.  
> 
> Noticed something.  In run.c run_with_files() allocates argv via g_malloc,
> but I can't seem to find where it is g_free()'d.  Can I assume it's a leak
> and go ahead and free it?

Yes, thanks! We need to find a way to use valgrind's memory checker on the
filer, but GTK caches a load of stuff and makes it difficult to spot the
real leaks...


-- 
Thomas Leonard			http://rox.sourceforge.net
tal00r at ecs.soton.ac.uk	tal197 at users.sourceforge.net
GPG: 9242 9807 C985 3C07 44A6  8B9A AE07 8280 59A5 3CC1