From: Thomas F. <tho...@ru...> - 2014-08-27 06:43:03
|
Hi, On Tuesday 26 August 2014 20:56:01 Milan Bouchet-Valat wrote: > OK, I think we are good now. I've added accessors for the > old .HTML.file, and this works at least with my package which uses it. > The checks look fine. > > I'm going to e-mail the maintainers of reverse dependencies and leave > them some time to reply before pushing to CRAN. Anything I may have > missed? just a nitpick: As a C++-developer I can't quite get used to it, myself, but I think "the R way" of a getter/setter pair is 'HTMLFile' <- function() {...} 'HTMLFile<-' <- function(filename) {...} Regards Thomas |