From: Derrick M. <der...@ax...> - 2003-07-02 06:47:38
|
Geert, That is some fine-looking code. I haven't tried it out yet, but it appears to be logical, cleanly written and well-commented. Has anyone verified that Geert's mods will run on a *nix server? As for 'absolute' mode, that just means 'scale the photo exactly to these dimensions', whereas 'constrain' means 'scale the photo to fit within a box this size, but maintain the original aspect ratio'. Does that address your question, or did I misunderstand what you were asking? Thanks! Derrick ----- Original Message ----- From: "Geert Eltink" <gee...@ho...> To: <gir...@ma...>; <pro...@li...> Sent: Friday, June 27, 2003 5:55 AM Subject: Re: [Props-general] Re: Problem with Photo > I have already made some changes to the photo functions, because I use a > windows server. It doesn't use the Magik stuff, only php functions. > > The only problem I had is the difference between 'absolute' and 'constrain'. > So it always works as 'constrain'. Maybe someone can change this. > > I hope this helps and get you started. > > Cheers, Geert. > > > > I hope I can send attachments to the mailing list.... > > > >From: girardot <gir...@ma...> > >To: pro...@li... > >Subject: Re: [Props-general] Re: Problem with Photo > >Date: Tue, 24 Jun 2003 23:41:17 -0400 > > > > > >----- Original Message ----- > >From: "Derrick Miller" <der...@ax...> > >To: <pro...@li...> > >Sent: Tuesday, June 24, 2003 3:44 PM > >Subject: Re: [Props-general] Re: Problem with Photo > > > > > > > > I agree that it would make a better FAQ or README note then a patch. > > > > > > Or perhaps a config parameter... > > > >I think both. My previous experience with supporting an open source package > >that required image manipulation showed that the image libraries (IM I > >think > >it was) were the very hardest thing to get installed and running correctly. > >Spelling out the image manipulation library requirements in a faq and the > >install doc seems like a good idea and easy to do, i'll take care of it. > > > > > > Would it be better to create seperate GD functions, i.e. > > > > generate_scaled_photo_gd or just do something like > > > > if (get_config_param['use_gd') ) ?? > > > > > > Would it be better to just rip out all the ImageMagick calls and replace > > > them with GD calls? Or does the end user need to have a choice between > > > ImageMagick and GD? > > > >I am a bit of an above average user (just a bit above), and I had a heck of > >a time getting one or both of these packages installed and working > >correctly > >on various platforms in different situations (some hosted, some not). > > > >If there was any way to support both easily using the config paramater to > >let the installer decide which to use, I would vote for that. It would > >require a function for each transformation that had two simmilar versions > >of > >code in it, one set for GD and one for IM choosing which after checking the > >paramater. Not all that much of a problem to the code base I dont think, > >but > >more work for sure for the implamenter. I think images are manipulated just > >a few times in the system currently however. Or maybe there is a better way > >to support it. > > > >If the person who is suggesting this feels comfortable doing something like > >that, I think its best to support both if PROPS can, not just for > >convience, > >but for ease of portablity across platforms or environments as well. > > > >Barring the support for both, I think going with what recent versions of > >PHP > >are supporting is a good idea, as long as older versions of PHP can use it > >via an external mechanism as well. > > > >[ sorry if this arrives very late, my mail seems to be getting to the list > >days late sometimes. ] > > > >Cheers, > >Blake Girardot > > > > > > > > > >------------------------------------------------------- > >This SF.Net email is sponsored by: INetU > >Attention Web Developers & Consultants: Become An INetU Hosting Partner. > >Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! > >INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php > >_______________________________________________ > >Props-general mailing list > >Pro...@li... > >https://lists.sourceforge.net/lists/listinfo/props-general > > _________________________________________________________________ > Hotmail en Messenger on the move > http://www.msn.nl/communicatie/smsdiensten/hotmailsmsv2/ > |