From: Rafael L. <rla...@us...> - 2003-12-31 10:04:47
|
* Alan W. Irwin <ai...@us...> [2003-12-30 18:06]: > On 2003-12-31 01:46+0100 Rafael Laboissiere wrote: > > > I see something really weird in both Alan's and Koen's config.log. Those > > "-Idefault" and "-Ldefault" should *_never_* appear there. Alan, I think > > that you wrote that section of GD library checks in configure.ac. Haven't > > you forgot a call to ADD_TO_LIBS there? > > Thanks for spotting that. I agree that is weird and should not happen. > However, I don't think ADD_TO_LIBS (and ADD_TO_INCS) is necessary because > of the "default" logic that occurs in configure.ac. But somehow that > logic, e.g., > > GDLIBCMD= > if test "$GDLIBDIR" != default; then > GDLIBCMD="$GDLIBCMD -L$GDLIBDIR" > fi > > is failing. Should default be quoted? It appears elsewhere in configure.ac > that tests are sometimes done with the quotes on the second argument and > sometimes not. (I hate these m4 parsing issues). Strictly speaking, quotes are only really necessary when we have a variables on one of the sides of the comparison (like the "$GDLIBDIR" above). This prevents from the case where the variable is above or the variable contain special shell character (like spaces and the like). This has nothing to do with m4 parsing. To answer your question, both `default' and `"default"' should give *_exactly_* the same result under Bourne shell. I still think that ADD_TO_LIBS should be called after the GD, PNG, and JPEG checks, in the same way it is done for libcd, FreeType, and Gnome. Indeed, it is in this macro that the string "default" is coped with. -- Rafael |