[Plplot-devel] Implementation of build-system logic to test Tcl/Tk version consistency

[Alan W. I. <ir...@be...>]

On 2013-12-18 18:22-0800 Alan W. Irwin wrote:

> On 2013-12-18 23:45-0000 Andrew Ross wrote:
>
>> On Wed, Dec 18, 2013 at 03:27:28PM -0800, Alan Irwin wrote:
>>> On 2013-12-18 22:01-0000 Andrew Ross wrote:
>>>> One other issue I encountered was that detecting of the various tcl
>>>> components is not entirely robust. I had tcl8.5 and tcl8.6 installed.
>>>> On Ubuntu the default is tcl8.5 so tclsh points to tclsh8.5. This
>>>> means that most of the tcl-related variables were set to point to 8.5,
>>>> however the code setting TCL_INCLUDE_PATH ended up pointing to tcl8.6.
>>>> This is probably a cmake issue rather than a plplot issue, but I
>>>> thought I'd flag it up.
>>>
>>> Did our build system warn about those version inconsistencies?  And if
>>> so, could you straighten out CMake finding Tcl/Tk library versions
>>> that were inconsistent with tclsh by using CMAKE_INCLUDE_PATH and
>>> CMAKE_LIBRARY_PATH?
>>
>> No - the build system didn't warn of the inconsistencies. Well at least
>> cmake didn't. I spotted it by eye and to fix it I actually used
>> update-alternatives to make tclsh point to tclsh8.6 since that seemed
>> easiest.
>
> OK.  To deal with this issue post release, I will implement a check
> for tclsh consistency with the libtcl and libtk versions that the
> CMake find module finds.

Hi Andrew:

I have implemented a number of Tcl/Tk version consistency checks
in revision 12913.  Please run the Debian/Ubuntu update-alternatives
command for tclsh and wish to put versions of those commands on the
PATH which are inconsistent with each other and/or with the latest
Tcl/Tk libraries that CMake typically finds.  These requested tests
are to make sure users get a WARNING out of our build system whenever
there are inconsistent tclsh and wish choices.

By the way, one limitation of my cmake implemention of this new Tcl/Tk
version checking logic is I could find no fundamental way to discover
the version of the Tcl or Tk library that CMake finds (since
tclsh and wish just report back the Tcl/Tk version of the libraries
they are linked to which may be different than the libraries that
CMake finds).  So I fell back to parsing the library names delivered
by CMake (assumed to be in the form of, e.g., libtclNN.so or
libtclN.N.so) to determine the truncated version number N.N, and then
checking whether that truncated version number was consistent with
Tcl/Tk versions delivered by tclsh and wish.  So this logic is not
perfect, but I think it will work for most situations and if not
(i.e., no version number can be parsed from the library name), then it
just skips this aspect of the number of Tcl/Tk version consistency checks
that have been implemented.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________