From: Andrew R. <and...@us...> - 2009-05-09 10:09:21
|
On Fri, May 08, 2009 at 02:01:59PM -0700, Alan Irwin wrote: > P.S. I now see you actually committed a fix to pkg-config.cmake. Since my > changes dealt with the QT_LIBRARIES issue directly, I am wondering whether > we should revert your change (because I am not quite sure whether that logic > will always work properly) or just leave it in case some other library ever > exhibits the same issue that has just been fixed for QT_LIBRARIES. > > I would like to keep my changes since they do address the QT_LIBRARIES issue > in a way that I understand. We could also keep your changes since they > peacefully coexists with mine. However, yours is no longer necessary so I > leave it to you whether to revert it or not. Alan, As you say, they should coexist. My patch simply removes any optimized tags and libraries for debug builds, and otherwise removes any debug tags and libraries. It then removes the remaining tags which are not needed for pkg-config. It works for me. I'll comment it out for now, but leave the code there, then if the need arises for other libraries we can easily reinstate. It's only a relatively small patch. Andrew |