Re: [Plplot-devel] Removing special Windows logic concerning qsastime_testlib

[Arjen M. <arj...@de...>]

On 2009-05-06 07:25, Alan W. Irwin wrote:
> Hi Arjen:
> 
> To my knowledge, the work you did to get qsastime_testlib to build on
> Windows never gave useful test results because of limitations in the Windows
> C library time routines (e.g., no valid time results before 1970). I do
> appreciate the work you put into this; it was the only way we could discover
> those limitations in the Windows C library time routines. However, because
> of those limitations, I have removed (revision 9930) all the special Windows
> logic that you implemented in the build system and in the qsastime_testlib
> code, and instead simply changed the build system logic to not allow an
> attempt to build qsastime_testlib on Windows (i.e., when WIN32 is true).
> 
> With revision 9930, the qsastime_testlib.c code and the build system logic
> are much cleaner for platforms (64-bit Linux and possibly 64-bit Mac OS X)
> where qsastime_testlib actually produces useful results.
> 
> The new file lib/qsastime/README.qsastime_tests documents the applications
> (currently qsastime_test, bhunt_search_test, and qsastime_testlib) used to
> test the qsastime library.  Following directions in that file I checked that
> I could still use the revision 9930 qsastime_testlib to reproduce
> lib/qsastime/qsastime_testlib.out_standard on my 64-bit Linux platform.
> 
> I may not get to it this week, but I eventually plan to implement another
> test which simply compares extensive libqsastime results with a file.  That
> test should be useful on all platforms with no dependence on C library
> time-handling routines and therefore no issues concerning peculiarities of
> such time-handling routines on certain platforms.
> 

Hello Alan,

I do not remember the exact details, but indeed the 32-bits integers
that are used natively (at least by the almost ancient compiler I
normally use) are a severe limitation.

I think your plan is a good one: we know the programs will run on
Windows, so the basics are covered. With a test program that is
independent of the pecularities of the system libraries that happen
to be available it will be all the more useful. (I know many system
libraries have their quirks and blatant bugs ...)

Regards,

Arjen


Delft Hydraulics, GeoDelft, the Subsurface and Groundwater unit of TNO and parts of Rijkswaterstaat have joined forces in a new independent institute for delta technology, Deltares. Deltares combines knowledge and experience in the field of water, soil and the subsurface. We provide innovative solutions to make living in deltas, coastal areas and river basins safe, clean and sustainable. 

 

DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited.
The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.