From: Andrew R. <and...@us...> - 2004-01-30 22:34:07
|
On Wed, Jan 28, 2004 at 02:32:42PM +0100, Rafael Laboissiere wrote: > * Andrew Ross <and...@us...> [2004-01-28 12:45]: > > > The options look particularly convoluted. I particularly don't like the > > tcl_cmd bits appearing in plargs.c and plcore.c. Do you think it would > > be possible to switch these to use the driver options mechanism now? The > > commands are marked as invisible anyway so I doubt anything other than > > plrender uses them. If people think this would be a good idea I'll look > > into the feasibilty of it. > > I would say go for it. Driver specific stuff should not appear in the > src/*.c files. I have a patch which replaces the -tcl_cmd option with -drvopt tcl_cmd=. It also fixes some bugs in the handling of string values for driver options. It seems nobody has used this yet. It seems to work fine with plrender, however when I try running under valgrind with the tk driver it seems to hang. This may be a problem using valgrind with tcl, but I'd like to investigate further before committing anything. There are various other options such as server_name, auto_path and tk_file which are specific to the tk driver. What do people feel about these? If I change them I will make the old command bounce the option on to drvopt for now and print a message telling the user they are depreciated. I never use the so I'd like some input from people who do before I do anything drastic. Andrew |