Re: [Playerstage-developers] Stage bugs?

[brian g. <bg...@po...>]

> From: Richard Vaughan <va...@hr...>
> Date: Tue, 5 Feb 2002 15:00:33 -0800 (PST)
> 
> fixed the bug and tidied up the entity config buffer handling. bug was not
> new semaphore related - looks like when positiondevice configs were added,
> the messages are 2 bytes but m_config_len was set to 1 byte. Remember -
> the data/command/config buffers are statically allocated - none of these
> messages should vary in size, ever! made CEntity::GetConfig rather strict
> on config size.
> 
> you'll need a fresh player, as i added a nice tody
> player_position_config_t to messages.h
> 

rich,
  nice one there.  we definitely need to be strict with those buffers,
defining ALL of them as packed structs (and thus with fixed sizes).  
i suspect that there are still some buffers that are not so defined, 
leftovers from the old free-form days, before Andrew showed me the light....

if you see any such unstructured buffers (or unstructured access to structured
buffers) and have the gumption, please clean them up; they are an endless 
source of bugs.


        brian.