Re: [Playerstage-users] Problem in modifying Player structures

[Giulio Z. <Giu...@ir...>]

On Thu, 2008-02-14 at 08:02 +1300, Toby Collett wrote:
>         1) Data being wrote: I assume for no reason the GUID should be
>         changed.
>         I think also TYPE has no sense of being written, but if you
>         think it
>         could be a good option, I'll just add a switch or a field.
> 
> I am not sure what you mean by this? 

There are 2 sensitive field for now in the player_rfid_tag_t: type and
guid
I am adding another field to read/write data.
I will work with real tags, when simulation will be ok, and usually you
can by no means overwrite the GUID, so i think I will not provide this
option (and same for the type, I suppose).
I was just asking if someone interested in RFIDs (if any) disagrees with
that.


> The interface API for 2.0.X has been frozen so we wont accept patches
> for interface changes to 2.0 (but that would have been the correct way
> to do it)

Once I understood the way to modify, I am already considering a porting
on the 2.1.X for several reasons, and using a char* instead of an array
for GUID and Data is one of them.
I just need to wait a first stable release in that line, to agree with
the project partners.
If this could be interesting, I try to patch this before the upcoming
release.


>         3) Last but not least, in Player.h:4233 it says that
>         "Write to the RFID tag - to be implemented" So I wonder what
>         is the
>         correct procedure here.
>         I tried to imitate the structure from other proxies, so I
>         added a
>         WriteRFIDTag function in rfidproxy.cc, which calls
>         playerc_rfid_write_RFID_tag function in dev_rfid.c (defined in
>         Playerc.h). Everything seems to be ok on the Client side
>         but...
>         how do I communicate the changes to all others (i.e. to Player
>         server
>         and Stage)?
> 
> I dont recall how far the implementation is to start with, the should
> be a write request, or if not you can add one to the interface file,
> then the client can use this request to write data to the server.

Sorry I didn't quite get it. The write request seems not there, since (in 2.1.X version) it says, in file Player_interfaces.h 
/** Request/reply: write data to the RFID tag - to be implemented.
*/
#define PLAYER_RFID_REQ_WRITETAG 3
So, in which interface file should I add this? It's just that the point,
I don't understand how the client can write to the server... Formerly I
tried to send an opaque command, that was caught by the Driver which
updated ITS structures. Moreover, with dynamic pointers, there is not a
fixed structures to write (like for the position proxy wich has the
Pose).

Thanks