Well on investigation, I found that this is the problem only with columns that are containing data of integer type. If I am right, I would like to work on this bug.
Thank you
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Is this bug reproducible for only numerical columns or for any other data type too? As far as I know, numerical data are by default stored right-aligned in mysql table.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I have changed the alignment of the columns of all PMA tables to left alignment using CSS. As of now, all the data , no matter what data type is it, will be shown left -aligned. Is this the fix you wanted?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I couldn't find a branch named QA_4_3 in my list right now. Maybe I have
mistakenly deleted that branch. How can I re-create it from the QA_4_3
branch of master repository phpmyadmin?
Each time i make a pull request, i get a message from phomyadmin bot,
saying that my file contains trailing white spaces and it is offending the
rules.
I have removed all other spaces i used in my code. But i could not
understand why it is giving this error and how to solve it now and take
care in future?
On Feb 26, 2015 11:25 PM, "Marc Delisle" lem9@users.sf.net wrote:
I have created the final pull request ( previous issue on trailing
white-spaces solved, but I still would like to know its meaning and
permanent solution).
Each time i make a pull request, i get a message from phomyadmin bot,
saying that my file contains trailing white spaces and it is offending the
rules.
I have removed all other spaces i used in my code. But i could not
understand why it is giving this error and how to solve it now and take
care in future?
On Feb 26, 2015 11:25 PM, "Marc Delisle" lem9@users.sf.net wrote:
Like help_category_id,parent_category_id in help_category table in mysql db, right?
Well on investigation, I found that this is the problem only with columns that are containing data of integer type. If I am right, I would like to work on this bug.
Thank you
Just for confirming, should I start working on this bug?
Is this bug reproducible for only numerical columns or for any other data type too? As far as I know, numerical data are by default stored right-aligned in mysql table.
Yes, it's only an issue for numbers.
I have changed the alignment of the columns of all PMA tables to left alignment using CSS. As of now, all the data , no matter what data type is it, will be shown left -aligned. Is this the fix you wanted?
Like this..
Of course not. Numbers should be right-aligned.
Ok.sorry that I misunderstood the bug. I think i have 2 solutions for this.
But my semester exams are going on. Can I get some more time to solve it?
Last edit: Marc Delisle 2015-02-20
This bug ticket remains open and anyone may work on it.
Last edit: Marc Delisle 2015-02-20
I think I have solved the bug.
I adjusted the header alignment for all the header fields of numeric columns to right alignment.
I would like to open a pull request.
Can anyone tell me which branch should I target to push my commits?
Branch: QA_4_3
I couldn't find a branch named QA_4_3 in my list right now. Maybe I have
mistakenly deleted that branch. How can I re-create it from the QA_4_3
branch of master repository phpmyadmin?
Last edit: Marc Delisle 2015-02-26
The exact answer depends on your git configuration but see:
https://wiki.phpmyadmin.net/pma/Git#Working_with_branches
maybe replacing "origin" with a different reference.
Each time i make a pull request, i get a message from phomyadmin bot,
saying that my file contains trailing white spaces and it is offending the
rules.
I have removed all other spaces i used in my code. But i could not
understand why it is giving this error and how to solve it now and take
care in future?
On Feb 26, 2015 11:25 PM, "Marc Delisle" lem9@users.sf.net wrote:
Related
Bugs:
#4746I have created the final pull request ( previous issue on trailing
white-spaces solved, but I still would like to know its meaning and
permanent solution).
commit id:-
https://github.com/phpmyadmin/phpmyadmin/commit/8bd66f82ae733042dd5e86d4b1a9c55682a10a36
pull reqest :-https://github.com/phpmyadmin/phpmyadmin/pull/1527
On Fri, Feb 27, 2015 at 2:44 AM, tapanhalani tapanhalani@users.sf.net
wrote:
Related
Bugs:
#4746Fix: https://github.com/phpmyadmin/phpmyadmin/pull/1527