Re: [Pdfedit-cvs] pdfedit/src/tools pdf_to_text.cc,1.5,1.6

[Michal H. <ms...@gm...>]

On Mon, Aug 08, 2011 at 12:54:05AM +0200, Jozef Misutka wrote:
> struct pdfedit_core_dev_init should be "smarter" and initialize its 
> members to default values

Default is - no special values. We inheritted this from xpdf code which
initializes all values from configuration file (which may not exist) or
command line parameters.

> e.g.
> 
> struct pdfedit_core_dev_init init;
> init.fontDir = ".";
> pdfedit_core_dev_init(&argc,&argv,&init);
> 
> is really tempting but very wrong indeed.

Why do you consider it wrong? pdfedit_core_dev_init calls init_xpdf_core
which in turn uses init->fontDir for global parameters initialization.
-- 
Michal Hocko