From: Jozef M. <mis...@ho...> - 2010-05-03 20:46:28
|
On Mon, 03 May 2010 22:43:53 +0200, Michal Hocko <ms...@gm...> wrote: > On Mon, May 03, 2010 at 10:37:54PM +0200, Jozef Misutka wrote: >> On Mon, 03 May 2010 22:36:09 +0200, Michal Hocko <ms...@gm...> >> wrote: >> >> >On Mon, Apr 19, 2010 at 08:50:40PM +0200, Michal Hocko wrote: >> >>On Sun, Apr 18, 2010 at 10:26:09PM +0000, Jozef Misutka wrote: >> >>> Update of /cvsroot/pdfedit/pdfedit/src/xpdf/xpdf >> >>> In directory sfp-cvsdas-2.v30.ch3.sourceforge.com:/tmp/cvs-serv17731 >> >>> >> >>> Modified Files: >> >>> SplashOutputDev.cc >> >>> Log Message: >> >>> >> >>> added null checks (otherwise crash on win32 test pdf file) >> >> >> >>This doesn't sound like a fix to me. How this can possibly happen? Is >> it >> >>just a bad code usage or a bug in the code? >> >> >> >>I don't like the change because it papers over maybe a real bug. >> >>Please revert the change and file a bug with the test pdf attached. >> >>Maybe we will find out that the crash is not windows specific. >> > >> >Please revert this change. >> >> i do not see why, we have already discussed it. > > What about arguments mentioned in this email. You have never answered > any of of them. > The only thing that came from you is that you don't have a document > which caused the issue. > Are we talking about the same thing? It doesn't seem so... arguments that we will rather wait for a crash than use this code? sorry, do not accept. jozef > >> >>> Index: SplashOutputDev.cc >> >>> =================================================================== >> >>> RCS file: >> /cvsroot/pdfedit/pdfedit/src/xpdf/xpdf/SplashOutputDev.cc,v >> >>> retrieving revision 1.6 >> >>> retrieving revision 1.7 >> >>> diff -u -d -r1.6 -r1.7 >> >>> --- SplashOutputDev.cc 11 Sep 2009 12:02:56 -0000 1.6 >> >>> +++ SplashOutputDev.cc 18 Apr 2010 22:26:06 -0000 1.7 >> >>> @@ -2553,6 +2553,8 @@ >> >>> const double *ctm; >> >>> >> >>> // restore state >> >>> + if (!transpGroupStack) >> >>> + return; >> >>> delete splash; >> >> >> >>This is a potential memory leak! >> >> >> >>> bitmap = transpGroupStack->origBitmap; >> >>> splash = transpGroupStack->origSplash; >> >>> @@ -2567,6 +2569,8 @@ >> >>> GBool isolated; >> >>> int tx, ty; >> >>> >> >>> + if (!transpGroupStack) >> >>> + return; >> >>> tx = transpGroupStack->tx; >> >>> ty = transpGroupStack->ty; >> >>> tBitmap = transpGroupStack->tBitmap; > -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ |