From: Michal H. <ms...@gm...> - 2009-09-10 11:48:52
|
On Tue, Sep 01, 2009 at 01:56:29PM +0200, Michal Hocko wrote: > This is the xpdf code clean-up patch series. The primary reason for it is to > make later kernel API cleanup easier. I will try to push parts of it to the > xpdf upstream but as there doesn't seem to be any activity there I might get > harder. We should, however, apply changes even without upstream submission. > > Changes are as non intrusive as possible. My primary intention is to add > const wherever possible and also some minor API updates (to have clean and > consistent way for object manipulation). > > The series is organized as follows: > * [patch 1/6] xpdf: Object accessor cleanup > - make Object accessors methods consistent > * [patch 2/6] xpdf: Stream dictionary accssor methods > - same like the above for Stream > * [patch 3/6] kernel: Do not use Dict, Array directly for modifications. > - do not modify object values directly but rather use Object > accessors methods. This is necessary for later Object const patch > * [patch 4/6] xpdf: GHash::{add,replace} const variants > - ghash uses rather tricky API for kyes and it is not obvious when > you have to provide an allocated string or the constant one. Let's > make it more obvious > * [patch 5/6] xpdf: use const for methods and parameters where possible > - jumbo patch which puts const wherever possible > * [patch 6/6] xpdf: Return const reference rather than Ref. > - minor patch for more effective Ref return value from > Object::getRef > > Check details directly in the patches. > Jozo, could you have a look at the series and try to compile it on Windows? Any chance you get to this anytime soon? -- Michal Hocko |