Re: Cannot compile *xref*

[Michal H. <ms...@gm...>]

On Sat, Aug 08, 2009 at 08:05:55AM +0000, Jozef Misutka wrote:
> 
> VS2008 cried about these errors, please fix them.

Strange that gcc didn't complain about that. 

I also remember that I updated those 3 places when I change Ref -> const Ref.
It must got lost somehow.

> 
> it is a good practise to use typedefs (you are using them on other places so why not typedef 

Old code which never got to cleanup...

> ObjectStorage< const ::Ref, ObjectEntry*, xpdf::RefComparator>

Fixed and committed. Thanks!

> 
> 
> /jozo
> 
> 
> 

Please use unified diff next time, it is much easier to review.

> Index: cxref.cc
> ===================================================================
> RCS file: /cvsroot/pdfedit/pdfedit/src/kernel/cxref.cc,v
> retrieving revision 1.48
> diff -r1.48 cxref.cc
> 65c65
> <     ObjectStorage< ::Ref, ObjectEntry*, xpdf::RefComparator>::Iterator i;
> ---
> >     ObjectStorage< const ::Ref, ObjectEntry*, xpdf::RefComparator>::Iterator i;
> 67c67,69
> <     for(i=changedStorage.begin(); i!=changedStorage.end(); ++i)
> ---
> >     for(i=changedStorage.begin(); 
> >         i!=changedStorage.end(); 
> >         ++i)
> 662c664
> <     ObjectStorage< ::Ref, RefState, xpdf::RefComparator>::Iterator begin, i;
> ---
> >     ObjectStorage< const ::Ref, RefState, xpdf::RefComparator>::Iterator begin, i;
> Index: xrefwriter.cc
> ===================================================================
> RCS file: /cvsroot/pdfedit/pdfedit/src/kernel/xrefwriter.cc,v
> retrieving revision 1.56
> diff -r1.56 xrefwriter.cc
> 503c503
> <     ObjectStorage< ::Ref, ObjectEntry *, xpdf::RefComparator>::Iterator i;
> ---
> >     ObjectStorage< const ::Ref, ObjectEntry *, xpdf::RefComparator>::Iterator i;
> 
> 
> _________________________________________________________________
> Windows Live?: Keep your life in sync.
> http://windowslive.com/explore?ocid=PID23384::T:WLMTAGL:ON:WL:en-US:NF_BR_sync:082009

-- 
Michal Hocko