RE: New CAnnotation implementation comments

[Jozef M. <mis...@ho...>]

----------------------------------------
> Date: Sun, 16 Mar 2008 14:27:47 +0100
> From: ms...@gm...
> To: pdf...@li...
> CC: mis...@ho...
> Subject: New CAnnotation implementation comments
> 
> - cpageannots.h:
>   /** 
>    * Registers observers for annotation synchronization.
>    * Checks type of given property and if it is reference, registers
>    * AnnotsPropWatchDog observer to it and dereferences indirect object. If 
>    * annots or dereferenced object is array, registers _annots_array_wd 
>    * observer to it and all its reference type elements.
>    *
>    * By default, it registers annotation observer for page dictionary.
>    *
>    * @param annots Annots property.
>    */
>   void reg_observers(boost::shared_ptr annots = boost::shared_ptr());
> 
>   It is little bit unintuitive what default means here. I would prefer:
>    * If annots is null object (or default parameter is used), it registers 
>    * annots observer on Annotation entry in page dictionary (should be used 
>    * only in constructor)
>   Same change should go to unreg_observers too.

ok.

> 
> - cpageannots.cc:
>   void egister_annots (shared_ptr annots
>   probably typo here (attached patch fixes it).
> 

not a typo.

> Other changes look good to me. Here is my ACK.
> 
> -- 
> Michal Hocko

_________________________________________________________________
Helping your favorite cause is as easy as instant messaging. You IM, we give.
http://im.live.com/Messenger/IM/Home/?source=text_hotmail_join