Re: [Pdfedit-devel] CVS Unified makefiles and configuration

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

I have made some changes to the devel-msts-unified_makefiles branch:

fixed help text for stack protector option (someone made a copy & paste 
error :))

Other suggestions:

> dnl FIXME what do we use src/utils/aconf.h for? No includes according to
> dnl grep. Can we remove it?

Now yes, but better would be to use it (what if mkdir/floor/other things 
that are being detected are not available?)

> dnl Checks for typedefs, structures, and compiler characteristics.
> dnl TODO where do we use output?

Not sure, but aren't the results in  src/utils/aconf.h ?

> --enable-qt3     Uses Qt3 infrastructure (use --disable-qt3 to
>                  use QT4 instead)

There won't be any version fully compilable with both qt3 and qt4 due to 
large incompatibilities between them. It may remain for testing in near 
future, but in longer future this will go away.

> dnl maybe asserts and stuff like that?

Asserts are always present unless -DNDEBUG is used

Also, because "configure" is automatically generated by autoconf from 
"configure.in", I suggest it would be removed from CVS and some "maint-
first" script that will run autoconf (and in future possibly also some 
other things) will be included. This script would be called by script that 
prepares ther distribution tarball.

Martin Petricek

   GPG/PGP Public key:  http://www.petricek.net/petricm.pgp
Fingerprint 6AA8 FFCE C061 1CB2 55F0  A1F3 3AA9 EB4F BD50 C1B8
/------------------------------------------------------------\
| WWW:                    http://www.petricek.net/           |
\------------------------------------------------------------/