From: JIRA (f. l. ) <ji...@pc...> - 2011-01-19 00:18:14
|
REQ - d20/Pathfinder move things around a little... --------------------------------------------------- Key: OS-54 URL: http://jira.pcgen.org/browse/OS-54 Project: Output Sheets Issue Type: New Feature Components: XSLT/PDF - Standard Fantasy Environment: all Reporter: ltwally Priority: Trivial The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. l. ) <ji...@pc...> - 2011-01-19 01:36:10
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11870#action_11870 ] ltwally commented on OS-54: --------------------------- I went ahead and did the work. It was easy, so why not. All changes are for "fantasy_master_std.xslt" 1) Under the "TEMPLATE - PAGE FOOTER" section, move the following from their original location to beneath "<xsl:apply-templates select="weapons"> </xsl:apply-templates>" to beneath "<xsl:apply-templates select="class_features/turning[@kind='UNDEAD']"> </xsl:apply-templates>": <xsl:apply-templates select="protection"/> <xsl:apply-templates select="class_features/rage"/> <xsl:apply-templates select="class_features/wildshape"/> <xsl:apply-templates select="class_features/stunning_fist"/> <xsl:apply-templates select="class_features/ki_pool"/> <xsl:apply-templates select="class_features/wholeness_of_body"/> <xsl:apply-templates select="class_features/layonhands"/> <xsl:apply-templates select="class_features/psionics"/> 2) Under the "TEMPLATE - Protection" section, change the following: <xsl:attribute name="column-width"><xsl:value-of select="0.55 * $pagePrintableWidth - 49" />mm</xsl:attribute> to: <xsl:attribute name="column-width"><xsl:value-of select="0.45 * $pagePrintableWidth - 47" />mm</xsl:attribute> 3) Under the "TEMPLATE - CLASS FEATURE PER DAY" section, change the following: <xsl:attribute name="column-width"><xsl:value-of select="0.55 * $pagePrintableWidth - 18" />mm</xsl:attribute> to: <xsl:attribute name="column-width"><xsl:value-of select="0.45 * $pagePrintableWidth - 18" />mm</xsl:attribute> That has worked for me, using 5.16.4. > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. l. ) <ji...@pc...> - 2011-01-19 01:36:11
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11870#action_11870 ] ltwally edited comment on OS-54 at 1/19/11 12:35 PM: ----------------------------------------------------- I went ahead and did the work. It was easy, so why not. All changes are for "fantasy_master_std.xslt" 1) Under the "TEMPLATE - PAGE FOOTER" section, move the following from their original location of beneath "<xsl:apply-templates select="weapons"> </xsl:apply-templates>" to beneath "<xsl:apply-templates select="class_features/turning[@kind='UNDEAD']"> </xsl:apply-templates>": <xsl:apply-templates select="protection"/> <xsl:apply-templates select="class_features/rage"/> <xsl:apply-templates select="class_features/wildshape"/> <xsl:apply-templates select="class_features/stunning_fist"/> <xsl:apply-templates select="class_features/ki_pool"/> <xsl:apply-templates select="class_features/wholeness_of_body"/> <xsl:apply-templates select="class_features/layonhands"/> <xsl:apply-templates select="class_features/psionics"/> 2) Under the "TEMPLATE - Protection" section, change the following: <xsl:attribute name="column-width"><xsl:value-of select="0.55 * $pagePrintableWidth - 49" />mm</xsl:attribute> to: <xsl:attribute name="column-width"><xsl:value-of select="0.45 * $pagePrintableWidth - 47" />mm</xsl:attribute> 3) Under the "TEMPLATE - CLASS FEATURE PER DAY" section, change the following: <xsl:attribute name="column-width"><xsl:value-of select="0.55 * $pagePrintableWidth - 18" />mm</xsl:attribute> to: <xsl:attribute name="column-width"><xsl:value-of select="0.45 * $pagePrintableWidth - 18" />mm</xsl:attribute> That has worked for me, using 5.16.4. was (Author: ltwally): I went ahead and did the work. It was easy, so why not. All changes are for "fantasy_master_std.xslt" 1) Under the "TEMPLATE - PAGE FOOTER" section, move the following from their original location to beneath "<xsl:apply-templates select="weapons"> </xsl:apply-templates>" to beneath "<xsl:apply-templates select="class_features/turning[@kind='UNDEAD']"> </xsl:apply-templates>": <xsl:apply-templates select="protection"/> <xsl:apply-templates select="class_features/rage"/> <xsl:apply-templates select="class_features/wildshape"/> <xsl:apply-templates select="class_features/stunning_fist"/> <xsl:apply-templates select="class_features/ki_pool"/> <xsl:apply-templates select="class_features/wholeness_of_body"/> <xsl:apply-templates select="class_features/layonhands"/> <xsl:apply-templates select="class_features/psionics"/> 2) Under the "TEMPLATE - Protection" section, change the following: <xsl:attribute name="column-width"><xsl:value-of select="0.55 * $pagePrintableWidth - 49" />mm</xsl:attribute> to: <xsl:attribute name="column-width"><xsl:value-of select="0.45 * $pagePrintableWidth - 47" />mm</xsl:attribute> 3) Under the "TEMPLATE - CLASS FEATURE PER DAY" section, change the following: <xsl:attribute name="column-width"><xsl:value-of select="0.55 * $pagePrintableWidth - 18" />mm</xsl:attribute> to: <xsl:attribute name="column-width"><xsl:value-of select="0.45 * $pagePrintableWidth - 18" />mm</xsl:attribute> That has worked for me, using 5.16.4. > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. C. P. ) <ji...@pc...> - 2011-01-19 03:50:13
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11871#action_11871 ] Chuck Pint commented on OS-54: ------------------------------ I may have to back this out. You missed some major things. First of all, all the code that works to make sure this all fits. Take a look at the template "features.left" and "features.right". Second, all the code I just put in last month so all the skills fit. Please don't make major changes like this without checking first. Sure it looked easy, but it will not work. > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. A. M. ) <ji...@pc...> - 2011-01-19 03:53:09
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11872#action_11872 ] Andrew Maitland commented on OS-54: ----------------------------------- Chuck, the user "Doing all the work" is just him posting what worked for him on his machine. No commits have been made against the pcgen svn system. > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. l. ) <ji...@pc...> - 2011-01-19 04:24:11
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11873#action_11873 ] ltwally commented on OS-54: --------------------------- Chuck, Didn't mean to offend -- just trying to help. I'm running 5.16.4, so I don't know about what new stuff you've been working on... However, in my system, "features.left" and "view.weapon.num" don't seem to do much, if anything. Again -- this is on 5.16.4. I can see how "features.right" can potentially effect things (and certainly my mods screw that up!). However, I'd like to point out that even with a large number of skills, there is still more room beneath the skills section than there is beneath just a couple weapons. ( I reckon at around 36 skills or so, its the same height as 2 weapons.) Example: My monk character sheet has, on the left column, 3 weapons + unarmed + flurry of blows. (I edited my XSLT sheet to allow more than 3 weapons on page 1.) On the right column containing 24 skills, the weapon proficiencies & languages (i moved them from page 2), my armor, stunning fist and ki pool. Even with all that stuff on the right-hand side, I still have room for another 18 or so skills. At any rate, it seems like maybe you were already working towards some sort of intelligent placement script/template/whatever, which was the whole point of my request: better placement for these items. Thanks > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. C. P. ) <ji...@pc...> - 2011-01-22 20:22:10
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11905#action_11905 ] Chuck Pint commented on OS-54: ------------------------------ This needs to be fixed, but not in the way shown. The features.left works correctly, but view.weapons.num has not worked for some time. I'm working on a more robust way to do view.weapons.num. One big problem with moving from one side to the other: left side is 55% and the right is 45% of the page width. Some things don't display properly unless they are left on the left. Big part of why earlier version of view_weapons.num is not working is that it doesn't take into account the "protection" block. Another reason is that not all weapons blocks are the same size. So this gets rather complex given all the variables. So I'm going to solicit some input and then we can decide whether or not to move these. > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. l. ) <ji...@pc...> - 2011-01-22 23:03:10
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11907#action_11907 ] ltwally commented on OS-54: --------------------------- Also, "view_weapons.num" doesn't take into account special properties on weapons. At any rate, I think it makes sense to move the "class.features.perday" stuff over to the righthand column. I've been experimenting with the classes, and after modifying "class.features.perday" to be 45% width, I haven't seen any real down-sides so far. (Though I've only tested Pathfinder, and don't claim to be an expert) > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. C. P. ) <ji...@pc...> - 2011-01-25 03:12:10
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Pint reassigned OS-54: ---------------------------- Assignee: Chuck Pint > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Assignee: Chuck Pint > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: JIRA (f. A. M. ) <ji...@pc...> - 2011-12-10 09:36:07
|
[ http://jira.pcgen.org/browse/OS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873#action_12873 ] Andrew Maitland commented on OS-54: ----------------------------------- Any further thoughts on this Chuck? > REQ - d20/Pathfinder move things around a little... > --------------------------------------------------- > > Key: OS-54 > URL: http://jira.pcgen.org/browse/OS-54 > Project: Output Sheets > Issue Type: New Feature > Components: XSLT/PDF - Standard Fantasy > Environment: all > Reporter: ltwally > Assignee: Chuck Pint > Priority: Trivial > > The area under the weapons is easily crowded, especially if you have more than a couple weapons. On the other hand, the area beneath the Skills is almost always wide open. And by wide open, I mean quite a bit of space. > I think it might be a good idea to move all the stuff between "protection" and "psionics" over to beneath the skills. Of course, they need their width resized to fit, but that's pretty easy. > If you really want to get slick, you could count the number of weapons vs the number of skill points and try to go from there. But even without going that far, I think it would be pretty good to have all the stuff that is normally shoved underneath the weapons pushed over to right side of page 1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |