From: Andrew M. (JIRA) <ji...@pc...> - 2010-08-14 20:18:28
|
HITDICEADVANCEMENT is not working as Documented ----------------------------------------------- Key: CODE-196 URL: http://jira.pcgen.org/browse/CODE-196 Project: Code Issue Type: Bug Affects Versions: 5.16.3 Reporter: Andrew Maitland Priority: Blocker Fix For: 5.16.3 Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag Wolf has HITDICEADVANCEMENT:3,6 Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Andrew M. (JIRA) <ji...@pc...> - 2010-08-14 20:18:29
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Maitland reassigned CODE-196: ------------------------------------ Assignee: James Dempsey > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: James Dempsey > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-14 20:22:27
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10763#action_10763 ] Stefan Radermacher commented on CODE-196: ----------------------------------------- HITDICEADVANCEMENT should not even be used in the Pathfinder RPG > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: James Dempsey > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Andrew M. (JIRA) <ji...@pc...> - 2010-08-14 20:39:27
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10764#action_10764 ] Andrew Maitland commented on CODE-196: -------------------------------------- Stefan, where does it say Pathfinder in this Code Bug? This is only affecting srd35. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: James Dempsey > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-14 21:04:30
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10765#action_10765 ] Stefan Radermacher commented on CODE-196: ----------------------------------------- Oops, my bad. I assumed Pathfinder RPG as you said "related to another tracker", which was a Pathfinder RPG issue. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: James Dempsey > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: James D. (JIRA) <ji...@pc...> - 2010-08-15 09:19:29
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10766#action_10766 ] James Dempsey commented on CODE-196: ------------------------------------ Tested in 35e mode, 5.16.x current with a normal wolf and that caps at 6HD with a size of large as expected. Useful information from the original report: Tested with PCGen 5.16.2 and 5.16.3RC3 RSRD 3.5 Complete The animal companion seems to get a size increase (and the appropriate stat modifications) when it is granted additional hit dice. AFAIK, this is incorrect. To reproduce: Create TN human druid 12 add wolf animal companion wolf is now Huge, with strength 33, con 23, etc. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: James Dempsey > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-15 10:05:28
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10767#action_10767 ] Stefan Radermacher commented on CODE-196: ----------------------------------------- I found a method (Race.sizesAdvanced) that calculates the number of size increases for a given number of HD to add. The value this method returns is too high by one if the new HD total exceeds the normal advancement limit. I'm using a fix now that makes this method return the correct value, however, this still does not solve the problem. Unfortunately this is difficult to trace, as this method is called literally hundreds(!) of times for a single "Update for Master"process, calculating that number over and over again. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: James Dempsey > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-15 10:08:28
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Radermacher reassigned CODE-196: --------------------------------------- Assignee: Stefan Radermacher (was: James Dempsey) > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: Stefan Radermacher > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-15 10:17:27
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10768#action_10768 ] Stefan Radermacher commented on CODE-196: ----------------------------------------- I discovered that the fix a actually working, it was the size adjustment workaround in the data that contributed to the error - the workaround is set to reduce the size only up to the maximum advancement limit. Once the companion advances beyond that limit, the compensational size reduction would no longer apply. I now have the wolf still at size M for level 20 druid. I will make sure the other companions work the same way and then commit the changes I made. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: Stefan Radermacher > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-15 10:41:28
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10769#action_10769 ] Stefan Radermacher commented on CODE-196: ----------------------------------------- This issue is now fixed in SVN revision 12830. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: Stefan Radermacher > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-15 11:00:28
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Radermacher updated CODE-196: ------------------------------------ Status: Confirmed (was: Open) Bug confimed and fixed already > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: Stefan Radermacher > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-15 11:00:29
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Radermacher updated CODE-196: ------------------------------------ Status: In Progress (was: Confirmed) > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: Stefan Radermacher > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-15 11:00:30
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Radermacher resolved CODE-196. ------------------------------------- Resolution: Fixed Fixed in SVN revision 12830. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: Stefan Radermacher > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Stefan R. (JIRA) <ji...@pc...> - 2010-08-15 11:50:29
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10772#action_10772 ] Stefan Radermacher commented on CODE-196: ----------------------------------------- The same problem appears in trunk, this is now fixed in SVN revision 12831. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: Stefan Radermacher > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Andrew M. (JIRA) <ji...@pc...> - 2010-08-16 05:30:30
|
[ http://jira.pcgen.org/browse/CODE-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Maitland closed CODE-196. -------------------------------- Works. > HITDICEADVANCEMENT is not working as Documented > ----------------------------------------------- > > Key: CODE-196 > URL: http://jira.pcgen.org/browse/CODE-196 > Project: Code > Issue Type: Bug > Affects Versions: 5.16.3 > Reporter: Andrew Maitland > Assignee: Stefan Radermacher > Priority: Blocker > Fix For: 5.16.3 > > > Related to another data tracker, I've discovered the Companions have broken by virtue of the HitDiceAdvancement tag > Wolf has > HITDICEADVANCEMENT:3,6 > Means it's Medium Sized till 4+ HD, and it caps at 6 HD with no further size increases. > The OP mentioned the Wolf was Huge Size, which means at 7+ it had another Size increase, which is invalid per the Monster Manual, and the Documented behavior of the HITDICEADVANCEMENT tag. > I can make a data workaround, but this behavior is strictly a Code Bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.pcgen.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |