[opentaps-issues] [ opentaps-Bugs-2632975 ] LedgerServices ignores INV_SPROD_ITEM

[SourceForge.net <no...@so...>]

Bugs item #2632975, was opened at 2009-02-24 09:57
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=763271&aid=2632975&group_id=145855

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: accounting
Group: weekly build
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Andreas (know_ag)
Assigned to: Nobody/Anonymous (nobody)
Summary: LedgerServices ignores INV_SPROD_ITEM

Initial Comment:
It is not possible to mark "service type product" invoice items to "ready". Reason is missing code in LedgerServices.java. In line 93 you find the declaration:
    public static final String INVOICE_PRODUCT_ITEM_TYPE = "INV_FPROD_ITEM";    // invoiceTypeId for invoice items which are products
which is o.k., but this is missing:
    public static final String INVOICE_SERVICE_ITEM_TYPE = "INV_SPROD_ITEM";    // invoiceTypeId for invoice items which are SERVICES
[...]
line 342 ff.:
                if ((invoiceItemTypeId.equals(INVOICE_PRODUCT_ITEM_TYPE))
                        || (invoiceItemTypeId.equals(INVOICE_SERVICE_ITEM_TYPE))
 ....

Now it works. This bug arises because formerly also service products were FPROD_ITEMs and now they are SPROD_ITEMS.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=763271&aid=2632975&group_id=145855