Menu ▾ ▴

#437 Regex \r\n replace fix

Next_release
closed
Don HO
None
9
2013-01-02
2012-11-27
Dave Brotherstone
No

Attached is a patch to fix the "Replace" button. It was always using the selection, even when there wasn't any, and "in selection" wasn't clicked. Due to the way "find next" works, this only affected certain searches, and only in regex mode. Reported here: https://sourceforge.net/p/notepad-plus/discussion/331753/thread/1bd87c0e/

Discussion

  • Dave Brotherstone

    Dave Brotherstone - 2012-11-27

    Patch can be applied with a command as follows:

    c:\utils\patxch.exe -p 1 -i E:\path\to\patches\0001-BUG_FIXED-Replace-on-some-text-doesn-t-work-e.g.-r-n.patch

    Obviously replacing the appropriate paths. patxch.exe is a renamed patch.exe from unxutils - http://unxutils.sourceforge.net/

     

  • Don HO

    Don HO - 2012-11-28

    Hi Dave,

    Thank you for the patch.
    It fixes indeed replacement bug of \r\n in RegExpr mode.

    However, I found a find bug of \r\n in RegExpr mode.

    Just enable "Extend mode" then count \r\n in file "0001-BUG_FIXED-Replace-on-some-text-doesn-t-work-e.g.-r-n.patch" you provided: 46 matches.

    Now enable "Regular Expression mode" then count \r\n in the same file: 43 matches.

    This bug makes result of "replace all" for "\r\n" incorrect.

    I checked FindReplaceDlg::processRange() function, it seems correct to me. Could there be a glitch in Scintilla part regarding PCRE?

    Don

     

  • Dave Brotherstone

    Dave Brotherstone - 2012-11-29

    I'll take a look. Certainly sounds like there's something else wrong
    somewhere. I'll probably not get chance to look at it till the weekend
    though.
    Cheers,
    Dave.
    On 29 Nov 2012 00:07, "Don HO" donho@users.sf.net wrote:

    Hi Dave,

    Thank you for the patch.
    It fixes indeed replacement bug of \r\n in RegExpr mode.

    However, I found a find bug of \r\n in RegExpr mode.

    Just enable "Extend mode" then count \r\n in file
    "0001-BUG_FIXED-Replace-on-some-text-doesn-t-work-e.g.-r-n.patch" you
    provided: 46 matches.

    Now enable "Regular Expression mode" then count \r\n in the same file: 43
    matches.

    This bug makes result of "replace all" for "\r\n" incorrect.

    I checked FindReplaceDlg::processRange() function, it seems correct to me.
    Could there be a glitch in Scintilla part regarding PCRE?

    Don

    [patches:#437] Regex \r\n replace fix

    Status: open
    Created: Tue Nov 27, 2012 06:59 PM UTC by Dave Brotherstone
    Last Updated: Tue Nov 27, 2012 07:01 PM UTC
    Owner: Don HO

    Attached is a patch to fix the "Replace" button. It was always using the
    selection, even when there wasn't any, and "in selection" wasn't clicked.
    Due to the way "find next" works, this only affected certain searches, and
    only in regex mode. Reported here:
    https://sourceforge.net/p/notepad-plus/discussion/331753/thread/1bd87c0e/

    Sent from sourceforge.net because you indicated interest in <
    https://sourceforge.net/p/notepad-plus/patches/437/>

    To unsubscribe from further messages, please visit <
    https://sourceforge.net/auth/prefs/>

     

  • Don HO

    Don HO - 2012-11-30
    • status: open --> accepted
    • priority: 5 --> 7
     

  • Dave Brotherstone

    Dave Brotherstone - 2012-12-02

    There was a bug in the BoostRegexSearch.cpp - it shifted the search start forward if the search start was at the end of a line or in-between line end characters. I don't know why it was like this. Removing this check fixes it, and I can't see any side effects.

     
    0001-Start-position-for-the-search-was-corrected-if-at-th.zip

  • Don HO

    Don HO - 2012-12-02

    Hi Dave,

    The bug is fixed by the last patch therefore the first patch is not apply.
    The patch is merged and committed in Rev. 990

    Thank you for the fix.
    Don

     

  • Don HO

    Don HO - 2012-12-02
    • priority: 7 --> 9
     

  • Don HO

    Don HO - 2013-01-02
    • status: accepted --> closed