From: Gerry S. <ger...@ya...> - 2001-12-19 01:44:10
|
Hi Jason, I've decided that I do not wish this task to be built into Nant by default but rather as an external optional task in a separate assembly. To use the tasks you need to add this line to the build file: <taskdef assembly="SourceSafe.NAnt.dll"/> See the UserTask example for more detail. The reasoning for this is that I want to keep nant totally portable so that when Mono starts running under linux nant will easily move to that platform. I'd still like to include the code in the distribution so I've made a subfolder under src called Extras where I plan to add these sorts of tasks. I don't have source safe on my machine so if you could do a get from cvs and see if this all works I'd appreciate it. If you don't have cvs access let me know and I'll email you a zip of the project. My next task is to get nightly .zip's of the cvs tree generated... Re: underscores, as soon as a large body publishes a coding convention that isn't too wacked I'll happily adopt it. I find the _ character is simpler than m_ and helps distinguish between class fields and local variables better than having to use 'this.' type of syntax. Gerry > -----Original Message----- > From: Jason Reimer [mailto:jpr...@ya...] > Sent: December 16, 2001 4:04 PM > To: Gerry Shaw > Subject: RE: NAnt project > > > Hi, > > I got some free time and I updated the source code to > conform with the projects conventions. If I may be so > bold, drop the _ before the variable names. Always > have hated 'em. I did however put them in the code to > be consistent. > > I also regenerated a new interop dll with the name > SourceSafe.Interop.dll. > > If you have any questions, please let me know. > > Jason > > > > --- Gerry Shaw <ger...@ya...> wrote: > > Great, I don't have SourceSafe so I can't test it > > but I was wondering if > > you could make the following small changes: > > > > 1. Rename the interop dll to something a bit > > smaller, say > > Interop.SourceSafe.dll, whatever makes sense but > > something short and > > clear. > > > > 2. Remove the VSS prefix from everything and place > > all the class in a > > new namespace called > > SourceForge.NAnt.Tasks.SourceSafe. In general > > avoid abbreviations and use SourceSafe instead of > > VSS. So > > SourceForge.NAnt.VSSBase would become > SourceForge.NAnt.SourceSafe.Base > > (or BaseTask). > > > > If you don't think you'll get that done within say a > > week let me know > > and I'll post the changes as is and make them myself > > in the future. > > > > This is a great contribution. > > Thanks! > > > > > > > -----Original Message----- > > > From: Jason Reimer [mailto:jpr...@ya...] > > > Sent: December 10, 2001 3:59 PM > > > To: Gerry Shaw > > > Subject: Re: NAnt project > > > > > > > > > Hi again, > > > > > > I've finished a set of 4 tasks for use with Visual > > > Source Safe. These are vssget, vsslabel, > > vsscheckin, > > > vsscheckout. I attached a zip file that contains > > these 4 > > > plus a base abstract class and a COM interop dll > > to the > > > Source Safe interface. They are not a direct port > > of the > > > Java tasks, either from a interface or > > implementation > > > perspectives, but they contain most if not more > > than the > > > functionality the Ant tasks. I have documented > > the tasks and > > > attributes fairly well using the doc comments. I > > may still > > > add additional attributes in the future, and if I > > do so I > > > will send you those updates. I've done a fair > > amount of > > > testing on these also, and I believe they are > > stable. > > > Honestly, you and the others did a great job with > > the > > > foundation, and it was very simple to build these > > tasks, so > > > consequently are not that complex to debug. > > > I was thinking of going back and adding a > > > StringValidatorAttribute class (for string length > > > validation) for some of this stuff, but that's > > just a > > > bell and whistle. > > > > > > I hadn't looked at your coding standards > > completely > > > before I started coding, so some of the variable > > > naming conventions vary from the existing tasks. > > If I > > > get some time, I will try and go back and change > > this > > > to be more uniform. > > > > > > If you have any questions, please let me know. > > > > > > Thanks, > > > > > > Jason > > > > > > > > > --- Gerry Shaw <ger...@ya...> wrote: > > > > I believe somebody is working on some cvs tasks > > but > > > > AFIK nobody has done the VSS tasks. If you > > could > > > > write a working task for VSS I'd love to include > > it > > > > in > > > > the distribution. I'm sure many others would > > find > > > > it > > > > quite useful. > > > > > > > > --- Jason Reimer <jpr...@ya...> wrote: > > > > > Hi, > > > > > > > > > > I got your email from the source forge web > > site, > > > > > after > > > > > looking at NAnt. I have noticed (or at least > > I > > > > > can't > > > > > find any) that you do not have any tasks for > > > > source > > > > > control systems yet. I am most interested in > > > > doing > > > > > automated builds, while integrating with > > Visual > > > > > Source > > > > > Safe. I was going to port the Ant VSS tasks > > to C# > > > > > for > > > > > this purpose, and was wondering if you would > > like > > > > me > > > > > to send you the code, or contribute to the > > project > > > > > in > > > > > some way. > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Jason Reimer > > > > > > > > > > > > __________________________________________________ > > > > > Do You Yahoo!? > > > > > Find the one for you at Yahoo! Personals > > > http://personals.yahoo.com > > > > > > > > > > > > > > > __________________________________________________ > > > > Do You Yahoo!? > > > > Yahoo! GeoCities - quick and easy web site > > hosting, > > > > just $8.95/month. > > > > http://geocities.yahoo.com/ps/info1 > > > > > > > > > ===== > > > Jason P. Reimer > > > jpr...@ya... > > > > > > __________________________________________________ > > > Do You Yahoo!? > > > Send your FREE holiday greetings online! > > http://greetings.yahoo.com > > > > > > > > ===== > Jason P. Reimer > jpr...@ya... > > __________________________________________________ > Do You Yahoo!? > Check out Yahoo! Shopping and Yahoo! Auctions for all of > your unique holiday gifts! Buy at http://shopping.yahoo.com > or bid at http://auctions.yahoo.com > |