@chud, I was unable to download the file. The link you've sent redirects to a page.
Please make sure you are using the latest version of ffmpedthumnailer and avcodec.
Minidlna already uses IN_CLOSE_WRITE event to call the thumbnail generation. If you are copying more than one file, the generation of the first will ovelap the second copy operation.
I'll upload a new patch for the latest commit in git fixing the bug (4).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I was building with FFmpeg 2.0.2 "Nameless", libavcodec 55. 18.102, and latest ffmpegthumbnailer, (ffmpeg 2.1 doesn't work with minidlna), (I have tried several older releases of everything too.) To be honest I have given up now . [I develop a 3rd party router firmware and was hoping to incorporate your patch]
I ended up using this torrent as my test 'Solaris [1972] 1080p Rus + Eng subs'
It is a BR rip with ~14 mkv's in the Extra's folder. The default thumb size of 160 would always crash it processing 'solaris_00317.mkv', setting thumb to 200 would work fine on all, setting it to something else (cant remember what, maybe 120) would make it fail on a different mkv.
Basically video_thumbnailer_generate_thumbnail_to_file() kills the minidlna thread dead if it tries something it dislikes. (i.e. presume fault with ffmpegthumbnailer/avcodec, I guess there isn't much you could do)
Anyway cheers for your hard work!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've tested with the solaris_00317.mkv with 160 and it worked fine here. In fact, I'm using this patch for more than 10 months now and I've never got a SEGFAULT. I'm using it on a raspberrypi with debian.
Anyhow, I'll work on removing the ffmpegthumbnailer as soon as I've got some free time.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
@eduardo, hmm thats interesting - any thoughts as to why the thumb size could have any effect? (I tried altering quality but made no difference). This is on MIPS incidently, ffmpeg had no special asm in it either. Anyway if you can remove need for ffmpegthumbnailer that hopefully will sort it so I wont worry about it now :)
Also if you are interested it struggled on avi's (specifically Greys Anatomy S08 xvid is all I tried), it appeared to try and seek and fail then say was using the first frame (black). (or words to that effect it was a week or so ago and I cannot remember what it was exactly) It would be about an order of magnitude slower on these avi's as mkv's presubably as it tried to seek through whole file? Just out of interest is this normal or not?
Thanks again, R
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
@eduardo rocha do you know the patch to correct folder structure. I am using it and it´s awesome for samsung tvs. I already use yours samsungES.patch and i will try this one tonight.
Regards from Brasil
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've seen you added a lot of updates to git repository, can you please add this thumbnail patch too? Users have to enable manually thumbnails creation at compile time if needed.
Thanks for your work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'm trying to apply thumbnails patch to v1.1.2 but when I run make, I get this error:
CC minidlna.o
In file included from minidlna.c:85:
options.h:67: error: expected ',' or '}' before 'FORCE_SORT_CRITERIA'
minidlna.c: In function 'init':
minidlna.c:711: error: 'FORCE_SORT_CRITERIA' undeclared (first use in this function)
minidlna.c:711: error: (Each undeclared identifier is reported only once
minidlna.c:711: error: for each function it appears in.)
minidlna.c:714: error: 'MAX_CONNECTIONS' undeclared (first use in this function)
make[2]: [minidlna.o] Error 1
make[2]: Leaving directory /var/tmp/b'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory/var/tmp/b'
make: [all] Error 2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks for the patch, I compiled and working fine on debian asuswrt mipsel routers http://forums.smallnetbuilder.com/showthread.php?t=14573, the only warning I get when I run make is:
CC upnpsoap.o
upnpsoap.c: In function 'parse_sort_criteria':
upnpsoap.c:514: warning: 'saveptr' may be used uninitialized in this function
CC upnpreplyparse.o
Last edit: TeHashX 2014-03-08
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi All,
The patch for version 1.1.2 as downloaded tonight does not work for ubuntu 12.04.
After applying the patch ./configure --enable-thumbnail warns about a non existing option --enable-thumbnail. Also the ffmpeg thumbnail libraries ar'nt checked although they are installed on the system.
After starting this new build minidlna binary complains about the thumbnail options in the config file and no thumbs are created.
Currently i'm using 1.0.25 with an earlier version of this patch without a problem. Hopefully it will be fixed because the extra sub directory option in 1.1.2 is my wish for a long time.
Last edit: kdeenkhoorn 2014-04-26
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Found it: i was missing the autoconf package and after installation that part was fixed.
I dit ./configure --enable-thumbs --enable-static
The static part failed during the make phase because of a missing -lgcc_s this was fixed editing:
configure.ac:
if test "$enableval" = "yes"; then
STATIC_CFLAGS="-DSTATIC"
AC_SUBST(STATIC_CFLAGS)
STATIC_LDFLAGS="-Wl,-Bstatic"
AC_SUBST(STATIC_LDFLAGS)
AC_MSG_RESULT([yes])
else
to
if test "$enableval" = "yes"; then
STATIC_CFLAGS="-DSTATIC"
AC_SUBST(STATIC_CFLAGS)
STATIC_LDFLAGS="-Wl -Bstatic"
AC_SUBST(STATIC_LDFLAGS)
AC_MSG_RESULT([yes])
else
Now i have a working minidlna daemon 1.1.2 for my Samsung UE32C6800.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi folks, here it goes the patch for minidlna 1.1.4. This is the last time I'll post it here since it will probably never get into the main branch. Feel free to keep it updated. Cheers!
Patches regarding video thumbnail has been around for more than 2 years now. Over that time, ARM CPU got much faster. Yes, it will make the scan process take a while longer but full scan happens once in a while if you have inotify enabled.
Anyhow, I've created a github repository to create features that will make my user experience better. Feel free to cherry pick them.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Status: open Group: Labels: Enhancements Created: Thu Dec 20, 2012 05:50 PM UTC by Eduardo Rocha Last Updated: Thu Dec 18, 2014 09:24 AM UTC Owner: Justin Maggard
Adding thumbnail generation to movies. Can be disabled at compile or
runtime.
@chud, I was unable to download the file. The link you've sent redirects to a page.
Please make sure you are using the latest version of ffmpedthumnailer and avcodec.
Minidlna already uses IN_CLOSE_WRITE event to call the thumbnail generation. If you are copying more than one file, the generation of the first will ovelap the second copy operation.
I'll upload a new patch for the latest commit in git fixing the bug (4).
Can you please provide the patch for v1.1.1?
Thanks
here it goes the patch for the git head that should work on v1.1.1.
Hi, I'm getting some errors patching the following files with '
minidlna_thumbnail_v1.1.1.patch':
options.c
options.h
If someone would be so kind to send to me.
Thanks.
Hi,
Where is the patch for 1.1.0?
http://sourceforge.net/p/minidlna/patches/92/?limit=10&page=1#0668
Ahh! I didn't see it, sorry.
@Eduardo
just tried - all links work?
I was building with FFmpeg 2.0.2 "Nameless", libavcodec 55. 18.102, and latest ffmpegthumbnailer, (ffmpeg 2.1 doesn't work with minidlna), (I have tried several older releases of everything too.) To be honest I have given up now . [I develop a 3rd party router firmware and was hoping to incorporate your patch]
I ended up using this torrent as my test 'Solaris [1972] 1080p Rus + Eng subs'
It is a BR rip with ~14 mkv's in the Extra's folder. The default thumb size of 160 would always crash it processing 'solaris_00317.mkv', setting thumb to 200 would work fine on all, setting it to something else (cant remember what, maybe 120) would make it fail on a different mkv.
Basically video_thumbnailer_generate_thumbnail_to_file() kills the minidlna thread dead if it tries something it dislikes. (i.e. presume fault with ffmpegthumbnailer/avcodec, I guess there isn't much you could do)
Anyway cheers for your hard work!
@chud,
I've tested with the solaris_00317.mkv with 160 and it worked fine here. In fact, I'm using this patch for more than 10 months now and I've never got a SEGFAULT. I'm using it on a raspberrypi with debian.
Anyhow, I'll work on removing the ffmpegthumbnailer as soon as I've got some free time.
@eduardo, hmm thats interesting - any thoughts as to why the thumb size could have any effect? (I tried altering quality but made no difference). This is on MIPS incidently, ffmpeg had no special asm in it either. Anyway if you can remove need for ffmpegthumbnailer that hopefully will sort it so I wont worry about it now :)
Also if you are interested it struggled on avi's (specifically Greys Anatomy S08 xvid is all I tried), it appeared to try and seek and fail then say was using the first frame (black). (or words to that effect it was a week or so ago and I cannot remember what it was exactly) It would be about an order of magnitude slower on these avi's as mkv's presubably as it tried to seek through whole file? Just out of interest is this normal or not?
Thanks again, R
@eduardo rocha do you know the patch to correct folder structure. I am using it and it´s awesome for samsung tvs. I already use yours samsungES.patch and i will try this one tonight.
Regards from Brasil
Thanks for minidlna_thumbnail_v1.1.1.patch, works great on asuswrt router
http://forums.smallnetbuilder.com/showthread.php?t=14573
I've seen you added a lot of updates to git repository, can you please add this thumbnail patch too? Users have to enable manually thumbnails creation at compile time if needed.
Thanks for your work
I'm trying to apply thumbnails patch to v1.1.2 but when I run make, I get this error:
CC minidlna.o
In file included from minidlna.c:85:
options.h:67: error: expected ',' or '}' before 'FORCE_SORT_CRITERIA'
minidlna.c: In function 'init':
minidlna.c:711: error: 'FORCE_SORT_CRITERIA' undeclared (first use in this function)
minidlna.c:711: error: (Each undeclared identifier is reported only once
minidlna.c:711: error: for each function it appears in.)
minidlna.c:714: error: 'MAX_CONNECTIONS' undeclared (first use in this function)
make[2]: [minidlna.o] Error 1
make[2]: Leaving directory
/var/tmp/b' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory/var/tmp/b'make: [all] Error 2
here it goes the patch based on yesterday git tree. Should work with 1.1.2.
Thanks for the patch, I compiled and working fine on debian asuswrt mipsel routers http://forums.smallnetbuilder.com/showthread.php?t=14573, the only warning I get when I run make is:
CC upnpsoap.o
upnpsoap.c: In function 'parse_sort_criteria':
upnpsoap.c:514: warning: 'saveptr' may be used uninitialized in this function
CC upnpreplyparse.o
Last edit: TeHashX 2014-03-08
Hi All,
The patch for version 1.1.2 as downloaded tonight does not work for ubuntu 12.04.
After applying the patch ./configure --enable-thumbnail warns about a non existing option --enable-thumbnail. Also the ffmpeg thumbnail libraries ar'nt checked although they are installed on the system.
After starting this new build minidlna binary complains about the thumbnail options in the config file and no thumbs are created.
Currently i'm using 1.0.25 with an earlier version of this patch without a problem. Hopefully it will be fixed because the extra sub directory option in 1.1.2 is my wish for a long time.
Last edit: kdeenkhoorn 2014-04-26
Found it: i was missing the autoconf package and after installation that part was fixed.
I dit ./configure --enable-thumbs --enable-static
The static part failed during the make phase because of a missing -lgcc_s this was fixed editing:
configure.ac:
if test "$enableval" = "yes"; then
STATIC_CFLAGS="-DSTATIC"
AC_SUBST(STATIC_CFLAGS)
STATIC_LDFLAGS="-Wl,-Bstatic"
AC_SUBST(STATIC_LDFLAGS)
AC_MSG_RESULT([yes])
else
to
if test "$enableval" = "yes"; then
STATIC_CFLAGS="-DSTATIC"
AC_SUBST(STATIC_CFLAGS)
STATIC_LDFLAGS="-Wl -Bstatic"
AC_SUBST(STATIC_LDFLAGS)
AC_MSG_RESULT([yes])
else
Now i have a working minidlna daemon 1.1.2 for my Samsung UE32C6800.
Can you update your patch for 1.1.3?
Attached file is my version of the patch.
Last edit: Раджа 2014-06-15
Hi folks, here it goes the patch for minidlna 1.1.4. This is the last time I'll post it here since it will probably never get into the main branch. Feel free to keep it updated. Cheers!
Last edit: Eduardo Rocha 2014-09-04
Thanx for the patch, I wonder why is not included?
Patches regarding video thumbnail has been around for more than 2 years now. Over that time, ARM CPU got much faster. Yes, it will make the scan process take a while longer but full scan happens once in a while if you have inotify enabled.
Anyhow, I've created a github repository to create features that will make my user experience better. Feel free to cherry pick them.
Your git link address?
Don't have git address.
On Thu, Feb 26, 2015 at 6:00 AM, TeHashX tehashx@users.sf.net wrote:
Related
Patches: #92
Sorry, I was asking Eduardo Rocha git address because he said here https://sourceforge.net/p/minidlna/patches/92/?limit=25&page=1#de59
"I've created a github repository to create features that will make my user experience better. Feel free to cherry pick them."