Menu ▾ ▴

#430 Msys fixes for Win9x

Patch_committed
closed-accepted
Cesar Strauss
msys (22)
2011-10-23
2009-10-22
Peter Hayward
No

This patch fixes bug 2853975 plus an additional bug on Win9x.
On running configure scripts I was getting the message

Cannot create temp file for here document : Permission denied.

In fact temp files were being created but unlink was failing as they were being unlinked before closing. The current _unlink() (syscalls.cc) relies on DeleteFile() marking open files for deletion on closure, which does not work on 9x. A lot of "unneeded" code has been removed (2006.08.07) from the 1.0.10 version, some of which is in fact needed. This patch reinstates the "delqueue" method for dealing with open files, which seems to be the only way that works on 9x.
This seems to restore reasonable operation, using it I have built wget from the mingwPORT plus a couple of other builds without further problems.
Hope this is useful to someone.

Related

Issues: #1347

Discussion

  • Peter Hayward

    Peter Hayward - 2009-10-22

    MsysWin9xpatch

     
    win9xfix.tar.gz

  • Earnie Boyd

    Earnie Boyd - 2009-10-23
    • assigned_to: earnie --> cstrauss
     

  • Cesar Strauss

    Cesar Strauss - 2009-10-27

    The patch looks good. The new code is conditional on Win9x, so it should not affect other systems. There should be no performance penalty either.

    I will apply it when I get the chance.

    Thank you for the effort.

    Cesar

     

  • Cesar Strauss

    Cesar Strauss - 2011-10-23

    The fix has been applied to CVS.

    Thanks for the patch!

    Cesar

     

  • Cesar Strauss

    Cesar Strauss - 2011-10-23
    • milestone: --> Patch_committed
    • status: open --> closed-accepted