From: SourceForge.net <no...@so...> - 2007-01-03 00:58:13
|
Patches item #1626560, was opened at 2007-01-03 01:58 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1626560&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: Patch committed Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Nijtmans (nijtmans) Assigned to: Nobody/Anonymous (nobody) Summary: wrong signature fore DdeCreateStringHandle(A|W) in ddeml.h Initial Comment: The second argument of those functions should be CONST. Contrary to the MSDN documentation, this is how Microsoft has it in its own header file. *** ddeml.h.orig Tue Jan 17 20:12:06 2006 --- ddeml.h Wed Nov 1 23:32:21 2006 *************** *** 259,266 **** HCONV WINAPI DdeConnect(DWORD,HSZ,HSZ,PCONVCONTEXT); HCONVLIST WINAPI DdeConnectList(DWORD,HSZ,HSZ,HCONVLIST,PCONVCONTEXT); HDDEDATA WINAPI DdeCreateDataHandle(DWORD,PBYTE,DWORD,DWORD,HSZ,UINT,UINT); ! HSZ WINAPI DdeCreateStringHandleA(DWORD,LPSTR,int); ! HSZ WINAPI DdeCreateStringHandleW(DWORD,LPWSTR,int); BOOL WINAPI DdeDisconnect(HCONV); BOOL WINAPI DdeDisconnectList(HCONVLIST); BOOL WINAPI DdeEnableCallback(DWORD,HCONV,UINT); --- 259,266 ---- HCONV WINAPI DdeConnect(DWORD,HSZ,HSZ,PCONVCONTEXT); HCONVLIST WINAPI DdeConnectList(DWORD,HSZ,HSZ,HCONVLIST,PCONVCONTEXT); HDDEDATA WINAPI DdeCreateDataHandle(DWORD,PBYTE,DWORD,DWORD,HSZ,UINT,UINT); ! HSZ WINAPI DdeCreateStringHandleA(DWORD,LPCSTR,int); ! HSZ WINAPI DdeCreateStringHandleW(DWORD,LPCWSTR,int); BOOL WINAPI DdeDisconnect(HCONV); BOOL WINAPI DdeDisconnectList(HCONVLIST); BOOL WINAPI DdeEnableCallback(DWORD,HCONV,UINT); ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1626560&group_id=2435 |
From: SourceForge.net <no...@so...> - 2007-02-11 14:00:09
|
Patches item #1626560, was opened at 2007-01-02 19:58 Message generated for change (Comment added) made by ir0nh34d You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1626560&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: Patch committed >Status: Closed >Resolution: Rejected Priority: 5 Private: No Submitted By: Jan Nijtmans (nijtmans) >Assigned to: Chris Sutcliffe (ir0nh34d) Summary: wrong signature fore DdeCreateStringHandle(A|W) in ddeml.h Initial Comment: The second argument of those functions should be CONST. Contrary to the MSDN documentation, this is how Microsoft has it in its own header file. *** ddeml.h.orig Tue Jan 17 20:12:06 2006 --- ddeml.h Wed Nov 1 23:32:21 2006 *************** *** 259,266 **** HCONV WINAPI DdeConnect(DWORD,HSZ,HSZ,PCONVCONTEXT); HCONVLIST WINAPI DdeConnectList(DWORD,HSZ,HSZ,HCONVLIST,PCONVCONTEXT); HDDEDATA WINAPI DdeCreateDataHandle(DWORD,PBYTE,DWORD,DWORD,HSZ,UINT,UINT); ! HSZ WINAPI DdeCreateStringHandleA(DWORD,LPSTR,int); ! HSZ WINAPI DdeCreateStringHandleW(DWORD,LPWSTR,int); BOOL WINAPI DdeDisconnect(HCONV); BOOL WINAPI DdeDisconnectList(HCONVLIST); BOOL WINAPI DdeEnableCallback(DWORD,HCONV,UINT); --- 259,266 ---- HCONV WINAPI DdeConnect(DWORD,HSZ,HSZ,PCONVCONTEXT); HCONVLIST WINAPI DdeConnectList(DWORD,HSZ,HSZ,HCONVLIST,PCONVCONTEXT); HDDEDATA WINAPI DdeCreateDataHandle(DWORD,PBYTE,DWORD,DWORD,HSZ,UINT,UINT); ! HSZ WINAPI DdeCreateStringHandleA(DWORD,LPCSTR,int); ! HSZ WINAPI DdeCreateStringHandleW(DWORD,LPCWSTR,int); BOOL WINAPI DdeDisconnect(HCONV); BOOL WINAPI DdeDisconnectList(HCONVLIST); BOOL WINAPI DdeEnableCallback(DWORD,HCONV,UINT); ---------------------------------------------------------------------- >Comment By: Chris Sutcliffe (ir0nh34d) Date: 2007-02-11 09:00 Message: Logged In: YES user_id=570619 Originator: NO We can only base the w32api headers on the publicly available information (i.e. MSDN), we cannot use the actual MS headers as a source of information for legal reasons. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1626560&group_id=2435 |
From: SourceForge.net <no...@so...> - 2007-02-23 23:31:59
|
Patches item #1626560, was opened at 2007-01-03 01:58 Message generated for change (Comment added) made by nijtmans You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1626560&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: Patch committed Status: Closed Resolution: Rejected Priority: 5 Private: No Submitted By: Jan Nijtmans (nijtmans) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: wrong signature fore DdeCreateStringHandle(A|W) in ddeml.h Initial Comment: The second argument of those functions should be CONST. Contrary to the MSDN documentation, this is how Microsoft has it in its own header file. *** ddeml.h.orig Tue Jan 17 20:12:06 2006 --- ddeml.h Wed Nov 1 23:32:21 2006 *************** *** 259,266 **** HCONV WINAPI DdeConnect(DWORD,HSZ,HSZ,PCONVCONTEXT); HCONVLIST WINAPI DdeConnectList(DWORD,HSZ,HSZ,HCONVLIST,PCONVCONTEXT); HDDEDATA WINAPI DdeCreateDataHandle(DWORD,PBYTE,DWORD,DWORD,HSZ,UINT,UINT); ! HSZ WINAPI DdeCreateStringHandleA(DWORD,LPSTR,int); ! HSZ WINAPI DdeCreateStringHandleW(DWORD,LPWSTR,int); BOOL WINAPI DdeDisconnect(HCONV); BOOL WINAPI DdeDisconnectList(HCONVLIST); BOOL WINAPI DdeEnableCallback(DWORD,HCONV,UINT); --- 259,266 ---- HCONV WINAPI DdeConnect(DWORD,HSZ,HSZ,PCONVCONTEXT); HCONVLIST WINAPI DdeConnectList(DWORD,HSZ,HSZ,HCONVLIST,PCONVCONTEXT); HDDEDATA WINAPI DdeCreateDataHandle(DWORD,PBYTE,DWORD,DWORD,HSZ,UINT,UINT); ! HSZ WINAPI DdeCreateStringHandleA(DWORD,LPCSTR,int); ! HSZ WINAPI DdeCreateStringHandleW(DWORD,LPCWSTR,int); BOOL WINAPI DdeDisconnect(HCONV); BOOL WINAPI DdeDisconnectList(HCONVLIST); BOOL WINAPI DdeEnableCallback(DWORD,HCONV,UINT); ---------------------------------------------------------------------- >Comment By: Jan Nijtmans (nijtmans) Date: 2007-02-24 00:31 Message: Logged In: YES user_id=61031 Originator: YES Actually, I found a public reference to the right signature. I don't know where Wine got it from: http://source.winehq.org/WineAPI/DdeCreateStringHandleA.html http://source.winehq.org/WineAPI/DdeCreateStringHandleW.html The original implementation has the problem that when calling DdeCreateStringHandleA(ddeInstance, TCL_DDE_SERVICE_NAME, 0) (From Tcl 8.5, tclWinDde.c various places) this will give a compiler warning when using the -Wwrite-strings option from the mingw compiler. I would like to get rid of those warnings, that's how I found out about this problem. Regards, Jan Nijtmans ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2007-02-11 15:00 Message: Logged In: YES user_id=570619 Originator: NO We can only base the w32api headers on the publicly available information (i.e. MSDN), we cannot use the actual MS headers as a source of information for legal reasons. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1626560&group_id=2435 |
From: SourceForge.net <no...@so...> - 2007-03-06 01:54:09
|
Patches item #1626560, was opened at 2007-01-02 19:58 Message generated for change (Comment added) made by ir0nh34d You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1626560&group_id=2435 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: w32api Group: Patch committed Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Jan Nijtmans (nijtmans) Assigned to: Chris Sutcliffe (ir0nh34d) Summary: wrong signature fore DdeCreateStringHandle(A|W) in ddeml.h Initial Comment: The second argument of those functions should be CONST. Contrary to the MSDN documentation, this is how Microsoft has it in its own header file. *** ddeml.h.orig Tue Jan 17 20:12:06 2006 --- ddeml.h Wed Nov 1 23:32:21 2006 *************** *** 259,266 **** HCONV WINAPI DdeConnect(DWORD,HSZ,HSZ,PCONVCONTEXT); HCONVLIST WINAPI DdeConnectList(DWORD,HSZ,HSZ,HCONVLIST,PCONVCONTEXT); HDDEDATA WINAPI DdeCreateDataHandle(DWORD,PBYTE,DWORD,DWORD,HSZ,UINT,UINT); ! HSZ WINAPI DdeCreateStringHandleA(DWORD,LPSTR,int); ! HSZ WINAPI DdeCreateStringHandleW(DWORD,LPWSTR,int); BOOL WINAPI DdeDisconnect(HCONV); BOOL WINAPI DdeDisconnectList(HCONVLIST); BOOL WINAPI DdeEnableCallback(DWORD,HCONV,UINT); --- 259,266 ---- HCONV WINAPI DdeConnect(DWORD,HSZ,HSZ,PCONVCONTEXT); HCONVLIST WINAPI DdeConnectList(DWORD,HSZ,HSZ,HCONVLIST,PCONVCONTEXT); HDDEDATA WINAPI DdeCreateDataHandle(DWORD,PBYTE,DWORD,DWORD,HSZ,UINT,UINT); ! HSZ WINAPI DdeCreateStringHandleA(DWORD,LPCSTR,int); ! HSZ WINAPI DdeCreateStringHandleW(DWORD,LPCWSTR,int); BOOL WINAPI DdeDisconnect(HCONV); BOOL WINAPI DdeDisconnectList(HCONVLIST); BOOL WINAPI DdeEnableCallback(DWORD,HCONV,UINT); ---------------------------------------------------------------------- >Comment By: Chris Sutcliffe (ir0nh34d) Date: 2007-03-05 20:54 Message: Logged In: YES user_id=570619 Originator: NO Commited to CVS ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2007-02-23 18:31 Message: Logged In: YES user_id=61031 Originator: YES Actually, I found a public reference to the right signature. I don't know where Wine got it from: http://source.winehq.org/WineAPI/DdeCreateStringHandleA.html http://source.winehq.org/WineAPI/DdeCreateStringHandleW.html The original implementation has the problem that when calling DdeCreateStringHandleA(ddeInstance, TCL_DDE_SERVICE_NAME, 0) (From Tcl 8.5, tclWinDde.c various places) this will give a compiler warning when using the -Wwrite-strings option from the mingw compiler. I would like to get rid of those warnings, that's how I found out about this problem. Regards, Jan Nijtmans ---------------------------------------------------------------------- Comment By: Chris Sutcliffe (ir0nh34d) Date: 2007-02-11 09:00 Message: Logged In: YES user_id=570619 Originator: NO We can only base the w32api headers on the publicly available information (i.e. MSDN), we cannot use the actual MS headers as a source of information for legal reasons. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=302435&aid=1626560&group_id=2435 |