From: <no...@so...> - 2002-07-26 10:33:53
|
Support Requests item #586935, was opened at 2002-07-26 18:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None Status: Open Priority: 5 Submitted By: David Armour (davidarmour) Assigned to: Nobody/Anonymous (nobody) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-05 20:52:35
|
Support Requests item #586935, was opened at 2002-07-26 06:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None >Status: Pending >Priority: 1 Submitted By: David Armour (davidarmour) >Assigned to: Danny Smith (dannysmith) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- >Comment By: Earnie Boyd (earnie) Date: 2002-08-05 16:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-11 09:19:02
|
Support Requests item #586935, was opened at 2002-07-26 18:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None Status: Pending Priority: 1 Submitted By: David Armour (davidarmour) Assigned to: Danny Smith (dannysmith) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-11 17:19 Message: Logged In: YES user_id=30442 In windres rcparse.y: if (($$.flags & ACC_VIRTKEY) == 0 && ($$.flags & (ACC_SHIFT | ACC_CONTROL | ACC_ALT)) != 0) rcparse_warning (_("inappropriate modifiers for non-VIRTKEY")); Apparently windres only allows modifiers like "ALT" for virtual keys (as opposed to ASCII characters). I think this is incorrect because my win32.hlp file has an example: "B", ID_ACCEL5, ALT ; ALT_SHIFT+B "I", ID_ACCEL6, CONTROL, VIRTKEY ; CTRL+I So I think this check in windres is incorrect, but it is in fact a warning not an error, and windres still produces an output file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-06 04:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-12 12:28:15
|
Support Requests item #586935, was opened at 2002-07-26 06:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None >Status: Open >Priority: 5 Submitted By: David Armour (davidarmour) >Assigned to: Luke Dunstan (infidel) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- >Comment By: Earnie Boyd (earnie) Date: 2002-08-12 08:28 Message: Logged In: YES user_id=15438 So, Luke, should the warning persist? Or, should this be patched to not issue the warning? Earnie. ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-11 05:19 Message: Logged In: YES user_id=30442 In windres rcparse.y: if (($$.flags & ACC_VIRTKEY) == 0 && ($$.flags & (ACC_SHIFT | ACC_CONTROL | ACC_ALT)) != 0) rcparse_warning (_("inappropriate modifiers for non-VIRTKEY")); Apparently windres only allows modifiers like "ALT" for virtual keys (as opposed to ASCII characters). I think this is incorrect because my win32.hlp file has an example: "B", ID_ACCEL5, ALT ; ALT_SHIFT+B "I", ID_ACCEL6, CONTROL, VIRTKEY ; CTRL+I So I think this check in windres is incorrect, but it is in fact a warning not an error, and windres still produces an output file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-05 16:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-13 02:35:54
|
Support Requests item #586935, was opened at 2002-07-26 18:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None Status: Open Priority: 5 Submitted By: David Armour (davidarmour) Assigned to: Luke Dunstan (infidel) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- >Comment By: Luke Dunstan (infidel) Date: 2002-08-13 10:35 Message: Logged In: YES user_id=30442 After some investigation, I am more confused :). The MSDN documentation mentions these parameters, among others: event, type, options event: the keystroke, which can be one of: "char" - a single character enclosed in quotation marks (optionally prefixed by ^) character - an integer value representing a character. The 'type' parameter must be ASCII. virtual-key character - an integer value representing a virtual key. The 'type' parameter must be VIRTKEY. The virtual key for alphanumeric keys can be specified by placing the uppercase letter or number in double quotation marks. type: Required only when the event parameter is a character or a virtual-key character [implying that it is not required for a quoted character]. options: ALT - Causes the accelerator to be activated only if the ALT key is down. **Applies only to virtual keys**. SHIFT - Causes the accelerator to be activated only if the SHIFT key is down. Applies only to virtual keys. ... Up to this point, it seems that windres is correct. However, the same page of MSDN contains an example contradicting this: "k", IDDELLIPSE, ALT ; alt k And compiling the following script: 0x20 ACCELERATORS BEGIN "k", 0x3333, ALT END Gives no warnings with the MS resource compiler, but this script: 0x20 ACCELERATORS BEGIN "g", 0x2222, CONTROL END Outputs this warning from MS RC: acc2.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY This behaviour seems logical because SHIFT can be specified for an ASCII character with an uppercase letter or other character, and CONTROL can be specified with the ^ prefix, while ALT cannot. In my opinion, windres should be changed to allow ALT for non-VIRTKEYs like MS RC. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-12 20:28 Message: Logged In: YES user_id=15438 So, Luke, should the warning persist? Or, should this be patched to not issue the warning? Earnie. ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-11 17:19 Message: Logged In: YES user_id=30442 In windres rcparse.y: if (($$.flags & ACC_VIRTKEY) == 0 && ($$.flags & (ACC_SHIFT | ACC_CONTROL | ACC_ALT)) != 0) rcparse_warning (_("inappropriate modifiers for non-VIRTKEY")); Apparently windres only allows modifiers like "ALT" for virtual keys (as opposed to ASCII characters). I think this is incorrect because my win32.hlp file has an example: "B", ID_ACCEL5, ALT ; ALT_SHIFT+B "I", ID_ACCEL6, CONTROL, VIRTKEY ; CTRL+I So I think this check in windres is incorrect, but it is in fact a warning not an error, and windres still produces an output file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-06 04:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-13 23:54:29
|
Support Requests item #586935, was opened at 2002-07-26 22:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None Status: Open Priority: 5 Submitted By: David Armour (davidarmour) Assigned to: Luke Dunstan (infidel) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- >Comment By: Danny Smith (dannysmith) Date: 2002-08-14 11:54 Message: Logged In: YES user_id=11494 Luke, are you going to submit the obvious patch to binutils? I've test with yesterdays CVS and no regressions. Patch approval should be no problem if you include the testcases from your last message, plus another one with SHIFT. Danny ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-13 14:35 Message: Logged In: YES user_id=30442 After some investigation, I am more confused :). The MSDN documentation mentions these parameters, among others: event, type, options event: the keystroke, which can be one of: "char" - a single character enclosed in quotation marks (optionally prefixed by ^) character - an integer value representing a character. The 'type' parameter must be ASCII. virtual-key character - an integer value representing a virtual key. The 'type' parameter must be VIRTKEY. The virtual key for alphanumeric keys can be specified by placing the uppercase letter or number in double quotation marks. type: Required only when the event parameter is a character or a virtual-key character [implying that it is not required for a quoted character]. options: ALT - Causes the accelerator to be activated only if the ALT key is down. **Applies only to virtual keys**. SHIFT - Causes the accelerator to be activated only if the SHIFT key is down. Applies only to virtual keys. ... Up to this point, it seems that windres is correct. However, the same page of MSDN contains an example contradicting this: "k", IDDELLIPSE, ALT ; alt k And compiling the following script: 0x20 ACCELERATORS BEGIN "k", 0x3333, ALT END Gives no warnings with the MS resource compiler, but this script: 0x20 ACCELERATORS BEGIN "g", 0x2222, CONTROL END Outputs this warning from MS RC: acc2.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY This behaviour seems logical because SHIFT can be specified for an ASCII character with an uppercase letter or other character, and CONTROL can be specified with the ^ prefix, while ALT cannot. In my opinion, windres should be changed to allow ALT for non-VIRTKEYs like MS RC. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-13 00:28 Message: Logged In: YES user_id=15438 So, Luke, should the warning persist? Or, should this be patched to not issue the warning? Earnie. ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-11 21:19 Message: Logged In: YES user_id=30442 In windres rcparse.y: if (($$.flags & ACC_VIRTKEY) == 0 && ($$.flags & (ACC_SHIFT | ACC_CONTROL | ACC_ALT)) != 0) rcparse_warning (_("inappropriate modifiers for non-VIRTKEY")); Apparently windres only allows modifiers like "ALT" for virtual keys (as opposed to ASCII characters). I think this is incorrect because my win32.hlp file has an example: "B", ID_ACCEL5, ALT ; ALT_SHIFT+B "I", ID_ACCEL6, CONTROL, VIRTKEY ; CTRL+I So I think this check in windres is incorrect, but it is in fact a warning not an error, and windres still produces an output file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-06 08:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-14 02:42:49
|
Support Requests item #586935, was opened at 2002-07-26 18:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None Status: Open Priority: 5 Submitted By: David Armour (davidarmour) Assigned to: Luke Dunstan (infidel) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- >Comment By: Luke Dunstan (infidel) Date: 2002-08-14 10:42 Message: Logged In: YES user_id=30442 It would take me some time to get the binutils source from CVS, so it would be quicker if you were to submit the patch that you have already tested. I don't mind either way, so if you don't have time I will do it. I can confirm that the following case gives a warning with MS RC: 0x20 ACCELERATORS BEGIN "z", 0x4444, SHIFT END acc4.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY ---------------------------------------------------------------------- Comment By: Danny Smith (dannysmith) Date: 2002-08-14 07:54 Message: Logged In: YES user_id=11494 Luke, are you going to submit the obvious patch to binutils? I've test with yesterdays CVS and no regressions. Patch approval should be no problem if you include the testcases from your last message, plus another one with SHIFT. Danny ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-13 10:35 Message: Logged In: YES user_id=30442 After some investigation, I am more confused :). The MSDN documentation mentions these parameters, among others: event, type, options event: the keystroke, which can be one of: "char" - a single character enclosed in quotation marks (optionally prefixed by ^) character - an integer value representing a character. The 'type' parameter must be ASCII. virtual-key character - an integer value representing a virtual key. The 'type' parameter must be VIRTKEY. The virtual key for alphanumeric keys can be specified by placing the uppercase letter or number in double quotation marks. type: Required only when the event parameter is a character or a virtual-key character [implying that it is not required for a quoted character]. options: ALT - Causes the accelerator to be activated only if the ALT key is down. **Applies only to virtual keys**. SHIFT - Causes the accelerator to be activated only if the SHIFT key is down. Applies only to virtual keys. ... Up to this point, it seems that windres is correct. However, the same page of MSDN contains an example contradicting this: "k", IDDELLIPSE, ALT ; alt k And compiling the following script: 0x20 ACCELERATORS BEGIN "k", 0x3333, ALT END Gives no warnings with the MS resource compiler, but this script: 0x20 ACCELERATORS BEGIN "g", 0x2222, CONTROL END Outputs this warning from MS RC: acc2.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY This behaviour seems logical because SHIFT can be specified for an ASCII character with an uppercase letter or other character, and CONTROL can be specified with the ^ prefix, while ALT cannot. In my opinion, windres should be changed to allow ALT for non-VIRTKEYs like MS RC. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-12 20:28 Message: Logged In: YES user_id=15438 So, Luke, should the warning persist? Or, should this be patched to not issue the warning? Earnie. ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-11 17:19 Message: Logged In: YES user_id=30442 In windres rcparse.y: if (($$.flags & ACC_VIRTKEY) == 0 && ($$.flags & (ACC_SHIFT | ACC_CONTROL | ACC_ALT)) != 0) rcparse_warning (_("inappropriate modifiers for non-VIRTKEY")); Apparently windres only allows modifiers like "ALT" for virtual keys (as opposed to ASCII characters). I think this is incorrect because my win32.hlp file has an example: "B", ID_ACCEL5, ALT ; ALT_SHIFT+B "I", ID_ACCEL6, CONTROL, VIRTKEY ; CTRL+I So I think this check in windres is incorrect, but it is in fact a warning not an error, and windres still produces an output file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-06 04:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-14 23:52:25
|
Support Requests item #586935, was opened at 2002-07-26 22:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None >Status: Closed Priority: 5 Submitted By: David Armour (davidarmour) Assigned to: Luke Dunstan (infidel) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- >Comment By: Danny Smith (dannysmith) Date: 2002-08-15 11:52 Message: Logged In: YES user_id=11494 Thanks for tracking this down Luke Fixed in official CVS Danny ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-14 14:42 Message: Logged In: YES user_id=30442 It would take me some time to get the binutils source from CVS, so it would be quicker if you were to submit the patch that you have already tested. I don't mind either way, so if you don't have time I will do it. I can confirm that the following case gives a warning with MS RC: 0x20 ACCELERATORS BEGIN "z", 0x4444, SHIFT END acc4.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY ---------------------------------------------------------------------- Comment By: Danny Smith (dannysmith) Date: 2002-08-14 11:54 Message: Logged In: YES user_id=11494 Luke, are you going to submit the obvious patch to binutils? I've test with yesterdays CVS and no regressions. Patch approval should be no problem if you include the testcases from your last message, plus another one with SHIFT. Danny ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-13 14:35 Message: Logged In: YES user_id=30442 After some investigation, I am more confused :). The MSDN documentation mentions these parameters, among others: event, type, options event: the keystroke, which can be one of: "char" - a single character enclosed in quotation marks (optionally prefixed by ^) character - an integer value representing a character. The 'type' parameter must be ASCII. virtual-key character - an integer value representing a virtual key. The 'type' parameter must be VIRTKEY. The virtual key for alphanumeric keys can be specified by placing the uppercase letter or number in double quotation marks. type: Required only when the event parameter is a character or a virtual-key character [implying that it is not required for a quoted character]. options: ALT - Causes the accelerator to be activated only if the ALT key is down. **Applies only to virtual keys**. SHIFT - Causes the accelerator to be activated only if the SHIFT key is down. Applies only to virtual keys. ... Up to this point, it seems that windres is correct. However, the same page of MSDN contains an example contradicting this: "k", IDDELLIPSE, ALT ; alt k And compiling the following script: 0x20 ACCELERATORS BEGIN "k", 0x3333, ALT END Gives no warnings with the MS resource compiler, but this script: 0x20 ACCELERATORS BEGIN "g", 0x2222, CONTROL END Outputs this warning from MS RC: acc2.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY This behaviour seems logical because SHIFT can be specified for an ASCII character with an uppercase letter or other character, and CONTROL can be specified with the ^ prefix, while ALT cannot. In my opinion, windres should be changed to allow ALT for non-VIRTKEYs like MS RC. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-13 00:28 Message: Logged In: YES user_id=15438 So, Luke, should the warning persist? Or, should this be patched to not issue the warning? Earnie. ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-11 21:19 Message: Logged In: YES user_id=30442 In windres rcparse.y: if (($$.flags & ACC_VIRTKEY) == 0 && ($$.flags & (ACC_SHIFT | ACC_CONTROL | ACC_ALT)) != 0) rcparse_warning (_("inappropriate modifiers for non-VIRTKEY")); Apparently windres only allows modifiers like "ALT" for virtual keys (as opposed to ASCII characters). I think this is incorrect because my win32.hlp file has an example: "B", ID_ACCEL5, ALT ; ALT_SHIFT+B "I", ID_ACCEL6, CONTROL, VIRTKEY ; CTRL+I So I think this check in windres is incorrect, but it is in fact a warning not an error, and windres still produces an output file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-06 08:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-21 01:01:08
|
Support Requests item #586935, was opened at 2002-07-26 18:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None Status: Closed Priority: 5 Submitted By: David Armour (davidarmour) Assigned to: Luke Dunstan (infidel) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- >Comment By: David Armour (davidarmour) Date: 2002-08-21 09:01 Message: Logged In: YES user_id=580773 Just a quick question: Has this patch/upgrade been done yet? If so where can I donwload it? Thanks, David :] ---------------------------------------------------------------------- Comment By: Danny Smith (dannysmith) Date: 2002-08-15 07:52 Message: Logged In: YES user_id=11494 Thanks for tracking this down Luke Fixed in official CVS Danny ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-14 10:42 Message: Logged In: YES user_id=30442 It would take me some time to get the binutils source from CVS, so it would be quicker if you were to submit the patch that you have already tested. I don't mind either way, so if you don't have time I will do it. I can confirm that the following case gives a warning with MS RC: 0x20 ACCELERATORS BEGIN "z", 0x4444, SHIFT END acc4.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY ---------------------------------------------------------------------- Comment By: Danny Smith (dannysmith) Date: 2002-08-14 07:54 Message: Logged In: YES user_id=11494 Luke, are you going to submit the obvious patch to binutils? I've test with yesterdays CVS and no regressions. Patch approval should be no problem if you include the testcases from your last message, plus another one with SHIFT. Danny ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-13 10:35 Message: Logged In: YES user_id=30442 After some investigation, I am more confused :). The MSDN documentation mentions these parameters, among others: event, type, options event: the keystroke, which can be one of: "char" - a single character enclosed in quotation marks (optionally prefixed by ^) character - an integer value representing a character. The 'type' parameter must be ASCII. virtual-key character - an integer value representing a virtual key. The 'type' parameter must be VIRTKEY. The virtual key for alphanumeric keys can be specified by placing the uppercase letter or number in double quotation marks. type: Required only when the event parameter is a character or a virtual-key character [implying that it is not required for a quoted character]. options: ALT - Causes the accelerator to be activated only if the ALT key is down. **Applies only to virtual keys**. SHIFT - Causes the accelerator to be activated only if the SHIFT key is down. Applies only to virtual keys. ... Up to this point, it seems that windres is correct. However, the same page of MSDN contains an example contradicting this: "k", IDDELLIPSE, ALT ; alt k And compiling the following script: 0x20 ACCELERATORS BEGIN "k", 0x3333, ALT END Gives no warnings with the MS resource compiler, but this script: 0x20 ACCELERATORS BEGIN "g", 0x2222, CONTROL END Outputs this warning from MS RC: acc2.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY This behaviour seems logical because SHIFT can be specified for an ASCII character with an uppercase letter or other character, and CONTROL can be specified with the ^ prefix, while ALT cannot. In my opinion, windres should be changed to allow ALT for non-VIRTKEYs like MS RC. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-12 20:28 Message: Logged In: YES user_id=15438 So, Luke, should the warning persist? Or, should this be patched to not issue the warning? Earnie. ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-11 17:19 Message: Logged In: YES user_id=30442 In windres rcparse.y: if (($$.flags & ACC_VIRTKEY) == 0 && ($$.flags & (ACC_SHIFT | ACC_CONTROL | ACC_ALT)) != 0) rcparse_warning (_("inappropriate modifiers for non-VIRTKEY")); Apparently windres only allows modifiers like "ALT" for virtual keys (as opposed to ASCII characters). I think this is incorrect because my win32.hlp file has an example: "B", ID_ACCEL5, ALT ; ALT_SHIFT+B "I", ID_ACCEL6, CONTROL, VIRTKEY ; CTRL+I So I think this check in windres is incorrect, but it is in fact a warning not an error, and windres still produces an output file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-06 04:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |
From: <no...@so...> - 2002-08-21 01:50:44
|
Support Requests item #586935, was opened at 2002-07-26 18:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 Category: None Group: None Status: Closed Priority: 5 Submitted By: David Armour (davidarmour) Assigned to: Luke Dunstan (infidel) Summary: windres problem Initial Comment: Just installed windres 2.12.90 hoping to resolve a problem I saw in windres 2.11.90 but it did not. My RC code is: IDC_MYACCEL ACCELERATORS BEGIN "?", IDM_ABOUT, ALT // error "/", IDM_ABOUT, ALT // error VK_F10, IDM_RUN, VIRTKEY "x", IDM_EXIT, ALT // error END With windres is gives the following error for the lines above marked //error :- "inappropriate modifiers for non-VIRTKEY" This code compiled fine with the Borland RC compiler. Can someone advise me if this is a bug or is something wrong with my code. Thanks. ---------------------------------------------------------------------- >Comment By: Luke Dunstan (infidel) Date: 2002-08-21 09:50 Message: Logged In: YES user_id=30442 The change has been made in the official binutils CVS (see http://sources.redhat.com/binutils/). Next time Mingw binutils is released, you can download the updated binaries, or if you really want to you can download and build the CVS version. Since the message is only a warning, not an error, there shouldn't be any urgent need for it to be fixed. ---------------------------------------------------------------------- Comment By: David Armour (davidarmour) Date: 2002-08-21 09:01 Message: Logged In: YES user_id=580773 Just a quick question: Has this patch/upgrade been done yet? If so where can I donwload it? Thanks, David :] ---------------------------------------------------------------------- Comment By: Danny Smith (dannysmith) Date: 2002-08-15 07:52 Message: Logged In: YES user_id=11494 Thanks for tracking this down Luke Fixed in official CVS Danny ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-14 10:42 Message: Logged In: YES user_id=30442 It would take me some time to get the binutils source from CVS, so it would be quicker if you were to submit the patch that you have already tested. I don't mind either way, so if you don't have time I will do it. I can confirm that the following case gives a warning with MS RC: 0x20 ACCELERATORS BEGIN "z", 0x4444, SHIFT END acc4.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY ---------------------------------------------------------------------- Comment By: Danny Smith (dannysmith) Date: 2002-08-14 07:54 Message: Logged In: YES user_id=11494 Luke, are you going to submit the obvious patch to binutils? I've test with yesterdays CVS and no regressions. Patch approval should be no problem if you include the testcases from your last message, plus another one with SHIFT. Danny ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-13 10:35 Message: Logged In: YES user_id=30442 After some investigation, I am more confused :). The MSDN documentation mentions these parameters, among others: event, type, options event: the keystroke, which can be one of: "char" - a single character enclosed in quotation marks (optionally prefixed by ^) character - an integer value representing a character. The 'type' parameter must be ASCII. virtual-key character - an integer value representing a virtual key. The 'type' parameter must be VIRTKEY. The virtual key for alphanumeric keys can be specified by placing the uppercase letter or number in double quotation marks. type: Required only when the event parameter is a character or a virtual-key character [implying that it is not required for a quoted character]. options: ALT - Causes the accelerator to be activated only if the ALT key is down. **Applies only to virtual keys**. SHIFT - Causes the accelerator to be activated only if the SHIFT key is down. Applies only to virtual keys. ... Up to this point, it seems that windres is correct. However, the same page of MSDN contains an example contradicting this: "k", IDDELLIPSE, ALT ; alt k And compiling the following script: 0x20 ACCELERATORS BEGIN "k", 0x3333, ALT END Gives no warnings with the MS resource compiler, but this script: 0x20 ACCELERATORS BEGIN "g", 0x2222, CONTROL END Outputs this warning from MS RC: acc2.rc (4): warning RC4203 : SHIFT or CONTROL used without VIRTKEY This behaviour seems logical because SHIFT can be specified for an ASCII character with an uppercase letter or other character, and CONTROL can be specified with the ^ prefix, while ALT cannot. In my opinion, windres should be changed to allow ALT for non-VIRTKEYs like MS RC. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-12 20:28 Message: Logged In: YES user_id=15438 So, Luke, should the warning persist? Or, should this be patched to not issue the warning? Earnie. ---------------------------------------------------------------------- Comment By: Luke Dunstan (infidel) Date: 2002-08-11 17:19 Message: Logged In: YES user_id=30442 In windres rcparse.y: if (($$.flags & ACC_VIRTKEY) == 0 && ($$.flags & (ACC_SHIFT | ACC_CONTROL | ACC_ALT)) != 0) rcparse_warning (_("inappropriate modifiers for non-VIRTKEY")); Apparently windres only allows modifiers like "ALT" for virtual keys (as opposed to ASCII characters). I think this is incorrect because my win32.hlp file has an example: "B", ID_ACCEL5, ALT ; ALT_SHIFT+B "I", ID_ACCEL6, CONTROL, VIRTKEY ; CTRL+I So I think this check in windres is incorrect, but it is in fact a warning not an error, and windres still produces an output file. ---------------------------------------------------------------------- Comment By: Earnie Boyd (earnie) Date: 2002-08-06 04:52 Message: Logged In: YES user_id=15438 Danny, do you have any insights? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=202435&aid=586935&group_id=2435 |