From: Charles W. <cwi...@us...> - 2009-10-25 19:20:47
Attachments:
mingw-pseudo-reloc-round2.patch
|
After the previous synchronization between cygwin and mingw, I took the result back to the mingw64 guys: https://sourceforge.net/tracker/?func=detail&atid=983355&aid=2885246&group_id=202880 Merging with them required a few additional changes, so now I'm bring that result back to mingw (and cygwin). There are some functional changes in this release -- derived from "upstream" mingw64. To wit: (a) more uniform handling of errors (b) no more need for assert() nor assert.h (c) *all* errors now result in an error message, and abort() [on mingw32 and mingw64]. This is the correct behavior IMO, and obviously the mingw64 guys feel that way too. Tested on mingw32 and cygwin. 2009-10-25 Charles Wilson <...> Sync pseudo-reloc.c with mingw64 * psuedo-reloc.c: Remove unnecessary includes. Forward declare _pei386_runtime_relocator. Decorate _image_base__ symbol with macro for mingw64 compatibility. Whitespace changes. (__print_reloc_error): Renamed to... (__report_error): This. "Returns" void, and always aborts. Now used on all platforms. (__write_memory): Remove special case error handling for different platforms - always call __report_error. (do_pseudo_reloc): Remove special case error handling for different platforms - always call __report_error. (_pei386_runtime_relocator): Decorate _image_base__ symbol with mingw64 compatibility macro. OK to commit? -- Chuck |
From: Charles W. <cwi...@us...> - 2009-10-25 19:25:31
Attachments:
mingw-pseudo-reloc-round2.patch
|
Oops. posted the wrong version. The one attached here differs from the previous only in the location of the forward declaration of _pei386_runtime_relocator. This one actually matches mingw64. -- Chuck |
From: Chris S. <ir0...@gm...> - 2009-10-26 11:23:32
|
> Oops. posted the wrong version. The one attached here differs from the > previous only in the location of the forward declaration of > _pei386_runtime_relocator. This one actually matches mingw64. Please commit. Chris -- Chris Sutcliffe http://emergedesktop.org |
From: Charles W. <cwi...@us...> - 2009-10-26 13:48:06
|
Chris Sutcliffe wrote: >> Oops. posted the wrong version. The one attached here differs from the >> previous only in the location of the forward declaration of >> _pei386_runtime_relocator. This one actually matches mingw64. > > Please commit. Done, thx. -- Chuck |
From: Charles W. <cwi...@us...> - 2009-10-26 14:41:39
|
Charles Wilson wrote: > Chris Sutcliffe wrote: >>> Oops. posted the wrong version. The one attached here differs from the >>> previous only in the location of the forward declaration of >>> _pei386_runtime_relocator. This one actually matches mingw64. >> Please commit. > > Done, thx. Aaaargh. While preparing the final synchronization patch for the mingw64 folks, I noticed a *second* error path that I had not yet tested -- and it had the same bug. The attached patch fixes that one (the synchronization patch I just sent to the mingw64 guys includes this change). 2009-10-26 Charles Wilson <...> Resync with cygwin. * pseudo-reloc.c (__report_error) [CYGWIN]: Correct size bug regarding error messages. OK? (and sorry for all the churn; hopefully this is the last of it) -- Chuck |
From: Charles W. <cwi...@us...> - 2009-11-02 02:37:28
|
Charles Wilson wrote: > Aaaargh. While preparing the final synchronization patch for the > mingw64 folks, I noticed a *second* error path that I had not yet tested > -- and it had the same bug. The attached patch fixes that one (the > synchronization patch I just sent to the mingw64 guys includes this change). > > 2009-10-26 Charles Wilson <...> > > Resync with cygwin. > * pseudo-reloc.c (__report_error) [CYGWIN]: Correct size bug > regarding error messages. > > OK? (and sorry for all the churn; hopefully this is the last of it) Ping? This is the last step needed to fully synchronize cygwin, mingw64, and mingw32 editions of pseudo-reloc.c... -- Chuck |
From: Chris S. <ir0...@gm...> - 2009-11-02 03:46:43
|
Hey Chuck, >> Aaaargh. While preparing the final synchronization patch for the >> mingw64 folks, I noticed a *second* error path that I had not yet tested >> -- and it had the same bug. The attached patch fixes that one (the >> synchronization patch I just sent to the mingw64 guys includes this change). >> >> 2009-10-26 Charles Wilson <...> >> >> Resync with cygwin. >> * pseudo-reloc.c (__report_error) [CYGWIN]: Correct size bug >> regarding error messages. >> >> OK? (and sorry for all the churn; hopefully this is the last of it) > > Ping? This is the last step needed to fully synchronize cygwin, > mingw64, and mingw32 editions of pseudo-reloc.c... Sorry, your original reply got buried in my inbox and I ended up skipping it somehow... Please apply this patch. Cheers! Chris -- Chris Sutcliffe http://emergedesktop.org |
From: Charles W. <cwi...@us...> - 2009-11-02 12:28:45
|
Chris Sutcliffe wrote: >> Ping? This is the last step needed to fully synchronize cygwin, >> mingw64, and mingw32 editions of pseudo-reloc.c... > > Sorry, your original reply got buried in my inbox and I ended up > skipping it somehow... Please apply this patch. Done. -- Chuck |