From: Danny S. <dan...@cl...> - 2005-04-23 04:44:55
|
> -----Original Message----- > From: min...@li... > [mailto:min...@li...] On Behalf Of > Wu Yongwei > Sent: Saturday, April 02, 2005 12:46 AM > To: min...@li... > Subject: [MinGW-dvlpr] MBCS patch etc. for dirent.c > > > Hi Earnie and Danny, > > Please check whether the attached patches are appropriate. > The first makes some stylistic changes (when I went through > the file), and the second addresses a MBCS/UNICODE problem. > > N.B. To build a MBCS-safe version, _MBCS must be defined when > compiling dirent.c (i.e. building libmingwex.a). > > The ChangeLogs: > > 1. > > 2005-04-01 Wu Yongwei <ad...@sh...> > > mingwex/dirent.c: Make stylistic changes (SPACEs and TABs) for > GNU coding standard conformance. > Are you sure that that this is conformant to GNU coding standards? This doesn't look right to me: @@ -75,8 +75,10 @@ _topendir (const _TCHAR *szPath) /* Allocate enough space to store DIR structure and the complete * directory path given. */ - nd = (_TDIR *) malloc (sizeof (_TDIR) + (_tcslen(szFullPath) + _tcslen (SLASH) + - _tcslen(SUFFIX) + 1) * sizeof(_TCHAR)); + nd = (_TDIR *) malloc (sizeof (_TDIR) + (_tcslen (szFullPath) + + _tcslen (SLASH) + + _tcslen (SUFFIX) + 1) * + sizeof (_TCHAR)); if (!nd) { > 2. > > 2005-04-01 Wu Yongwei <ad...@sh...> > > mingwex/dirent.c (_topendir): Make the end-of-path slash check > MBCS-safe. > This looks OK. > Best regards, > > Yongwei > > -- > No virus found in this incoming message. > Checked by AVG Anti-Virus. > Version: 7.0.308 / Virus Database: 266.9.0 - Release Date: 3/31/2005 > > > -- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.10.2 - Release Date: 4/21/2005 |
From: Danny S. <dan...@cl...> - 2005-04-24 07:46:05
|
> -----Original Message----- > From: min...@li... > [mailto:min...@li...] On Behalf Of > Wu Yongwei > Sent: Sunday, April 24, 2005 6:50 PM > To: min...@li... > Subject: Re: [MinGW-dvlpr] MBCS patch etc. for dirent.c > > > Danny Smith wrote: > > > > >>-----Original Message----- > >>From: min...@li... > >>[mailto:min...@li...] On Behalf Of > >>Wu Yongwei > >>Sent: Saturday, April 02, 2005 12:46 AM > >>To: min...@li... > >>Subject: [MinGW-dvlpr] MBCS patch etc. for dirent.c > >> > >> > >>Hi Earnie and Danny, > >> > >>Please check whether the attached patches are appropriate. > >>The first makes some stylistic changes (when I went through > >>the file), and the second addresses a MBCS/UNICODE problem. > >> > >>N.B. To build a MBCS-safe version, _MBCS must be defined when > >>compiling dirent.c (i.e. building libmingwex.a). > >> > >>The ChangeLogs: > >> > >>1. > >> > >>2005-04-01 Wu Yongwei <ad...@sh...> > >> > >> mingwex/dirent.c: Make stylistic changes (SPACEs and TABs) for > >> GNU coding standard conformance. > >> > > > > > > Are you sure that that this is conformant to GNU coding standards? > > This doesn't look right to me: @@ -75,8 +75,10 @@ _topendir (const > > _TCHAR *szPath) > > > > /* Allocate enough space to store DIR structure and the complete > > * directory path given. */ > > - nd = (_TDIR *) malloc (sizeof (_TDIR) + (_tcslen(szFullPath) + > > _tcslen (SLASH) + > > - _tcslen(SUFFIX) + 1) * sizeof(_TCHAR)); > > + nd = (_TDIR *) malloc (sizeof (_TDIR) + (_tcslen (szFullPath) + > > + _tcslen (SLASH) + > > + _tcslen (SUFFIX) + 1) * > > + sizeof (_TCHAR)); > > > > if (!nd) > > { > > 1. The GNU coding standard seems to prefer inserting a space > after the > function name, although I cannot find a reference for it. All the > examples are given that way. OK > > 2. Though not spelt out, 80 column width is preferred. I googled and > found this: > http://lists.gnu.org/archive/html/monit-dev/2004-03/msg00023.html OK 3. According to the GNU coding standard, expressions should be split before an operator. The original dirent.c did not follow this, and I think this rule sometimes makes code alignment more difficult. So I did not follow this, either. But.. The operator should start the new line continuation not end the old line. Eg Foo = bar + buzz + bazz * z; Not Foo = bar + buzz + bazz * z; Anyway, it was not standard before so I won't loose sleep if the formatting changes aren't strict GNU Danny On my screen, the patched file has two sizeof's aligned at the same column, and three _tcslen's aligned at another. Best regards, Yongwei ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ MinGW-dvlpr mailing list Min...@li... https://lists.sourceforge.net/lists/listinfo/mingw-dvlpr -- No virus found in this incoming message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.10.2 - Release Date: 4/21/2005 -- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.10.2 - Release Date: 4/21/2005 |
From: Wu Y. <ad...@sh...> - 2005-04-24 09:59:25
Attachments:
dirent.c.1.patch
dirent.c.2.patch
|
Danny Smith wrote: > But.. > > > The operator should start the new line continuation not end the old > line. Eg > > Foo = bar > + buzz > + bazz > * z; > > Not > > Foo = bar + > buzz + > bazz * > z; > > Anyway, it was not standard before so I won't loose sleep if the > formatting changes > aren't strict GNU > Danny I did not change that because: 1) I did not want to change too much; 2) the long lines are easier to align if the split occurs after the operator; and 3) I really missed this rule then :-(. If you want strict GNU conformance, see the attachments. Best regards, Yongwei |
From: Earnie B. <ea...@us...> - 2005-04-25 22:06:56
|
On 9:54:13 am 2005-04-24 Wu Yongwei <ad...@sh...> wrote: > Danny Smith wrote: > > > But.. > > > > > > The operator should start the new line continuation not end the old > > line. Eg > > > > Foo = bar > > + buzz > > + bazz > > * z; > > > > Not > > > > Foo = bar + > > buzz + > > bazz * > > z; > > > > Anyway, it was not standard before so I won't loose sleep if the > > formatting changes > > aren't strict GNU > > Danny > > I did not change that because: 1) I did not want to change too much; > 2) the long lines are easier to align if the split occurs after the > operator; and 3) I really missed this rule then :-(. > > If you want strict GNU conformance, see the attachments. > Since it isn't GNU we don't need GNU conformance. If we were using GPL I might have a different opinion. Earnie |
From: Danny S. <dan...@cl...> - 2005-04-24 10:28:27
|
> -----Original Message----- > From: min...@li... > [mailto:min...@li...] On Behalf Of > Wu Yongwei > Sent: Sunday, April 24, 2005 9:54 PM > To: min...@li... > Subject: Re: [MinGW-dvlpr] MBCS patch etc. for dirent.c > > If you want strict GNU conformance, see the attachments. Thanks. Committed to CVS. Danny > > Best regards, > > Yongwei > > -- > No virus found in this incoming message. > Checked by AVG Anti-Virus. > Version: 7.0.308 / Virus Database: 266.10.2 - Release Date: 4/21/2005 > > > -- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.10.2 - Release Date: 4/21/2005 |
From: Wu Y. <ad...@sh...> - 2005-04-24 06:52:22
|
Danny Smith wrote: > >>-----Original Message----- >>From: min...@li... >>[mailto:min...@li...] On Behalf Of >>Wu Yongwei >>Sent: Saturday, April 02, 2005 12:46 AM >>To: min...@li... >>Subject: [MinGW-dvlpr] MBCS patch etc. for dirent.c >> >> >>Hi Earnie and Danny, >> >>Please check whether the attached patches are appropriate. >>The first makes some stylistic changes (when I went through >>the file), and the second addresses a MBCS/UNICODE problem. >> >>N.B. To build a MBCS-safe version, _MBCS must be defined when >>compiling dirent.c (i.e. building libmingwex.a). >> >>The ChangeLogs: >> >>1. >> >>2005-04-01 Wu Yongwei <ad...@sh...> >> >> mingwex/dirent.c: Make stylistic changes (SPACEs and TABs) for >> GNU coding standard conformance. >> > > > Are you sure that that this is conformant to GNU coding standards? > This doesn't look right to me: > @@ -75,8 +75,10 @@ _topendir (const _TCHAR *szPath) > > /* Allocate enough space to store DIR structure and the complete > * directory path given. */ > - nd = (_TDIR *) malloc (sizeof (_TDIR) + (_tcslen(szFullPath) + > _tcslen (SLASH) + > - _tcslen(SUFFIX) + 1) * sizeof(_TCHAR)); > + nd = (_TDIR *) malloc (sizeof (_TDIR) + (_tcslen (szFullPath) + > + _tcslen (SLASH) + > + _tcslen (SUFFIX) + 1) * > + sizeof (_TCHAR)); > > if (!nd) > { 1. The GNU coding standard seems to prefer inserting a space after the function name, although I cannot find a reference for it. All the examples are given that way. 2. Though not spelt out, 80 column width is preferred. I googled and found this: http://lists.gnu.org/archive/html/monit-dev/2004-03/msg00023.html 3. According to the GNU coding standard, expressions should be split before an operator. The original dirent.c did not follow this, and I think this rule sometimes makes code alignment more difficult. So I did not follow this, either. On my screen, the patched file has two sizeof's aligned at the same column, and three _tcslen's aligned at another. Best regards, Yongwei |