From: Danny S. <dan...@cl...> - 2004-08-28 03:06:37
|
Yongwei, Could you please look at this recent change to gthr-win32.h. It looks okay to me, but you are more expert on this: http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02293.html Danny |
From: Wu Y. <ad...@sh...> - 2004-08-28 13:15:22
|
Danny Smith wrote: > Yongwei, > > Could you please look at this recent change to gthr-win32.h. It looks > okay to me, but you are more expert on this: > > http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02293.html > > Danny I found some minor problems. In ./gcc/config/i386/gthr-win32.c: * "InterlockedDecrement (&mx->lock_idx)" must be a typo of "... (&mutex->counter)" In ./gcc/gthr-win32.h: * DWORD is used in the definition of __gthread_recursive_mutex_t, should it be changed to long? * "#define __GTHREAD_RECURSIVE_MUTEX_INIT_FUNCTION __gthread_mutex_init_function" must be a typo: __gthread_recursive_mutex_init_function should have been intended * __GTHREAD_RECURSIVE_MUTEX_INIT_DEFAULT is best defined as "{-1, 0, 0, 0}" * Definition of __gthread_recursive_mutex_init_function for the case of __GTHREAD_HIDE_WIN32API is missing, which should be like static inline int __gthread_recursive_mutex_init_function (__gthread_recursive_mutex_t *mutex) { if (__gthread_active_p ()) return __gthr_win32_recursive_mutex_init_function (mutex); else return 0; } * Same problem of "InterlockedDecrement (&mx->lock_idx)" as in gthr-win32.c. Best regards, Yongwei |