Menu ▾ ▴

#1838 Correct TLS alignment.

WSL
pending
Earnie Boyd
duplicate? (8) tls (3) needs review (58) needs test (57)
Task
later
Feature_in_WSL_4.1
True
2013-02-21
2012-01-16
Daniel Green
No

_tls_used offsets the start of the tls section by adding 1 to _tls_start.

I feel this is incorrect in two respects. The first is that _tls_start is defined as a char so adding 1 only increments by 1 byte.

Second secrel32 generates an offset from the start of the section. By offsetting from _tls_start the secrel32 offset becomes invalid and has the potential to allow access to invalid memory.

I also see no reason _tls_used should be placed in the TLS section. Other compilers treat is as read only and place it in .rdata.

See the included patch for my suggested changes.

Discussion

  • Daniel Green

    Daniel Green - 2012-01-16

    Corrected TLS alignment. Removed _tls_used from section .tls.

     
    mingwrt_tlssup.patch

  • Earnie Boyd

    Earnie Boyd - 2013-02-14

    Ticket moved from /p/mingw/patches/508/

     

  • Earnie Boyd

    Earnie Boyd - 2013-02-14
    • labels: MinGW runtime --> duplicate?
    • status: open --> pending
    • assigned_to: Earnie Boyd
    • milestone: --> WSL
    • type: --> Task
    • resolution: --> later
    • category: --> Unknown
    • patch_attached: --> True
     

  • Earnie Boyd

    Earnie Boyd - 2013-02-21
    • labels: duplicate? --> duplicate?, tls, needs review, needs test
    • category: Unknown --> Feature_in_WSL_4.1