From: SourceForge.net <no...@so...> - 2012-11-25 05:50:40
|
Patches item #2945712, was opened at 2010-02-03 21:23 Message generated for change (Comment added) made by wohler You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=313357&aid=2945712&group_id=13357 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Bazaar >Status: Closed Resolution: Fixed Priority: 6 Private: No Submitted By: Ted Phelps (tphelps) Assigned to: Bill Wohler (wohler) Summary: Postpone junk processing Initial Comment: The attached patch adds new marks to the mh-e folder view to flag messages as white- or black-listed, so that the training of the junk mail filter can be postponed until mh-execute-commands is invoked. This makes the behavior more consistent with the way refile and delete are already performed, makes it possible to undo a mis-labelling and moves the potentially slow junk mail filter training operation into a less inconvenient part of the workflow. I hope you find it useful. Thanks, -Ted ---------------------------------------------------------------------- >Comment By: Bill Wohler (wohler) Date: 2012-11-24 21:50 Message: The documentation is consistent with mh-refile-msg, for example, so closing without changing the documentation. ---------------------------------------------------------------------- Comment By: Bill Wohler (wohler) Date: 2012-01-12 21:19 Message: (In Spock voice) Fascinating. Thanks, Ted! ---------------------------------------------------------------------- Comment By: Ted Phelps (tphelps) Date: 2012-01-12 20:54 Message: Looking through the OED, I see the noun form starting as "blacke list" (1624) becoming "black list" (1774) and finally "blacklist" (2003). Given that "white list" (1900) is newer, it's not unreasonable to expect it to follow the same path and lose its space over time. Let's stick with "blacklist" and "whitelist". -Ted ---------------------------------------------------------------------- Comment By: Bill Wohler (wohler) Date: 2012-01-08 21:45 Message: You're right! They don't have the verb form of whitelist either. Hmmm. Anyone know what's up with that? The Oxford dictionary has the verb form of white list (with space) though. Weird. Seems that both whitelist and blacklist should have the same form. ---------------------------------------------------------------------- Comment By: Ted Phelps (tphelps) Date: 2012-01-08 21:34 Message: Thanks for the explanation! Amusing: m-w.com offers definitions for "blacklist" (but not "black list") and "white list" (but not "whitelist"). That said, I'm not about to propose we use "blacklist" and "white-list". ---------------------------------------------------------------------- Comment By: Bill Wohler (wohler) Date: 2012-01-08 21:25 Message: Hi Ted, thanks for the mh-exec-cmd info. We use blacklist and whitelist (without the dash) in MH-E because that's the way they are defined in the Merriam Webster dictionary. Even the Oxford dictionary lists blacklist and whitelist. ---------------------------------------------------------------------- Comment By: Ted Phelps (tphelps) Date: 2012-01-08 20:39 Message: Thanks Bill. Sorry I wasn't available on IRC when you were looking into this. I've scanned the differences between my patch and yours and I'm happy with all of the change. (Well, I like to put a hyphen in blacklist, but I'm not going to open that can of worms). I saw that you added a TODO about why mh-exec-cmd was used in mh-blacklist. I'm not certain, but I believe the reason is that mh-exec-cmd can process a whole list of messages in a single call, whereas mh-{refile|delete}-a-msg must spawn a new process for each message. I haven't done any testing to see if there's an observable performance difference between the two approaches, but I figured my changes were extensive enough without changing this too. Thanks! -Ted ---------------------------------------------------------------------- Comment By: Bill Wohler (wohler) Date: 2011-12-27 16:49 Message: Here are some variables that might need documentation updates: mh-before-commands-processed-hook (can now access mh-blacklist and mh-whitelist), mh-execute-commands, mh-whitelist-msg-hook, mh-blacklist-msg-hook, mh-index-execute-commands, mh-scan-blacklisted-msg-regexp, mh-scan-whitelisted-msg-regexp, mh-note-blacklisted, mh-note-whitelisted, mh-scan-good-msg-regexp. Edited output of release-utils --variable-changes previous-tag ** New Variables in MH-E XXX *** mh-blacklist-msg-hook *** mh-whitelist-msg-hook *** mh-whitelist-preserves-sequences-flag ** New Faces in MH-E XXX *** mh-folder-blacklisted *** mh-folder-whitelisted ---------------------------------------------------------------------- Comment By: Bill Wohler (wohler) Date: 2011-12-27 16:06 Message: Changes have been committed. Ted, this was wonderful work. Thank you! Other than one fix to the faces to get it to compile on XEmacs, I didn't touch the logic. I made a few tweaks to fit in with MH-E conventions. Here's the complete list: - Changed white-list and black-list to whitelist and blacklist respectively. - Fixed typos. - Changed package-version to 8.4. - Alphabetized variables as appropriate. - Changed verbiage from "refiles and deletes" to "operations" as in "Perform the outstanding operations..." - Removed debugging message. - Fixed mh-autoload cookies in mh-junk.el. - Fixed mh-folder-blacklisted face to compile on XEmacs. I'll close this once I've updated the manual. revno: 106740 committer: Bill Wohler <wo...@ne...> branch nick: mh-e timestamp: Tue 2011-12-27 15:59:35 -0800 message: Postpone junk processing (closes SF #2945712). Patch submitted by Ted Phelps and refined by Bill Wohler. * mh-e.el (mh-blacklist, mh-whitelist): New variables. (mh-whitelist-preserves-sequences-flag): New option. (mh-before-commands-processed-hook): Update documentation. (mh-blacklist-msg-hook, mh-whitelist-msg-hook): New hooks. (mh-folder-blacklisted, mh-folder-whitelisted): New faces. * mh-folder.el (mh-folder-message-menu): Add "Junk" to "Undo." (mh-folder-font-lock-keywords): Add regexps for blacklisted and whitelisted messages. (mh-folder-mode): Add mh-blacklist and mh-whitelist variables. (mh-execute-commands): Update documentation. (mh-undo, mh-outstanding-commands-p, mh-process-commands) (mh-delete-a-msg, mh-refile-a-msg, mh-undo-msg): Handle blacklisted and whitelisted messages. * mh-junk.el (mh-junk-blacklist, mh-junk-whitelist): Update to put messages in blacklist and whitelist respectively for latter processing. (mh-blacklist-a-msg, mh-junk-whitelist-a-msg): New function to support previous functions. (mh-junk-blacklist-disposition): New function. (mh-junk-process-blacklist, mh-junk-process-whitelist): New functions that perform the blacklisting and whitelisting respectively that used to be performed by mh-junk-blacklist and mh-junk-whitelist. * mh-scan.el (mh-scan-blacklisted-msg-regexp) (mh-scan-whitelisted-msg-regexp): New scan line regexps. (mh-scan-good-msg-regexp): Add B and W characters to regexp. (mh-scan-cmd-note-width): Update documentation. (mh-note-blacklisted, mh-note-whitelisted): New scan line characters. * mh-search.el (mh-index-execute-commands): Handle blacklisted and whitelisted messages. modified: lisp/mh-e/ChangeLog lisp/mh-e/mh-e.el lisp/mh-e/mh-folder.el lisp/mh-e/mh-junk.el lisp/mh-e/mh-scan.el lisp/mh-e/mh-search.el ---------------------------------------------------------------------- Comment By: Bill Wohler (wohler) Date: 2011-12-26 21:11 Message: Bumping priority to reward Ted for submitting papers :-). ---------------------------------------------------------------------- Comment By: Bill Wohler (wohler) Date: 2011-12-26 21:09 Message: I confirmed your copyright assignment to the FSF. Thanks very much, Ted! You're right, it's a pretty big patch. I am *so* glad your papers are in order. If you aren't on holidays tomorrow, please try to pop into the #mh-e channel at irc.freenode.net and help me out while I merge it during our bug squashing party (BSP). ---------------------------------------------------------------------- Comment By: Ted Phelps (tphelps) Date: 2010-11-01 13:10 Message: I realize that everyone is quite busy. Would it make life easier if I were to break this up into a series of smaller, easier-to-review patches? -Ted ---------------------------------------------------------------------- Comment By: Ted Phelps (tphelps) Date: 2010-07-19 21:50 Message: My Emacs assignment/disclaimer paperwork is now complete (RT#548209), so this large-ish patch can now be considered GPL-friendly from a copyright point-of-view. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=313357&aid=2945712&group_id=13357 |