Menu

#796 Completing a refit causes NPE

Stable
closed
nobody
refit (22)
Out-of-Date
2015-09-13
2015-02-06
No

See log file.

1 Attachments

Related

Bugs: #789

Discussion

  • Dylan Myers

    Dylan Myers - 2015-02-07

    The log file in question is a mess, with all the other errors in it. However, as it plainly says, it cannot find all the parts. So, the real question is, what did you do to the parts?

     
  • Dylan Myers

    Dylan Myers - 2015-02-07
    • Resolution: None --> Accepted
    • Milestone: Undetermined --> Development
     
  • stopcomplaining2

    I didnt do anything to the parts, they remain in the warehouse stuck as "reserved for refit" from what i can tell.

     
  • Dylan Myers

    Dylan Myers - 2015-02-08

    Well, I'll look into this more in depth, but I've never had this behavior, despite doing literally thousands of refits over the past 3 years of playing.

     
    • stopcomplaining2

      I think i found the "missing" part. There should be some armor in the warehouse marked as "reserved for refit" but there are no pending refits. Would that be the missing part?

       
  • stopcomplaining2

    This has only started in the latest version...i suspect this might have something to do with some parts errorneously set to "UNKNOWN" tech level (like standard heatsinks).

     
  • Taharqa

    Taharqa - 2015-08-03
    • Milestone: Development --> Stable
     
  • Taharqa

    Taharqa - 2015-08-04

    Possibly related to bug [#893] then.

     

    Related

    Bugs: #893

  • scjazz

    scjazz - 2015-08-10

    Could it be the refits to a personal custom design are the ones that are bugged? I just had a PXH-1 convert to a 1D no problem. The next refit to finish was a Custom Archer and it caused an NPE.

    Nevermind... Griffin 1N refit to 1S NPE'd

    As a test I refit a Jenner D to a Jenner F... similar to the refit of PXH-1 to PXH-1D in that both refit a unit with ammo to one that has no ammo. It worked perfectly.

     

    Last edit: scjazz 2015-08-10
  • Taharqa

    Taharqa - 2015-08-20

    I can load the campaign you provided but there are no refits in process so I am not sure how to reproduce the bug. Can you give me further instructions on what to refit? Also, armor being left over with reserve to refit on it should be fixed in this release, but I should also add a check in the campaign loader so that if there is a part that is reserved for refit but the unit with the refit id is not refitting, the reservation will be lifted.

     
  • Pheonix Rising

    Pheonix Rising - 2015-08-22

    I might be able to get a bugged refit campaign up. If scjazz is right on the Griffin it should be very easy to reproduce. If not... As many of these as I have seen I really don't know how to best reproduce this.

     
  • Dylan Myers

    Dylan Myers - 2015-09-13

    I cannot duplicate this at all in current trunk, and I find it strange that I've never encountered it in all the refits I've done in MHQ over the last 3+ years.

    Can anyone confirm that it is still happening in the latest release?

     
  • Taharqa

    Taharqa - 2015-09-13
    • labels: --> refit
    • status: open --> closed
    • Resolution: Accepted --> Out-of-Date
     
  • Taharqa

    Taharqa - 2015-09-13

    As I said in the comment above, I cannot reproduce this with the file provided and the OP has not responded. I have made quite a few changes to the way refit reserved parts are tracked so if that was the source of the bug then it has been resolved. I also made quite a few changes to refits themselves. I think given the lack of info and the dated nature, we should close this bug and see if any new NPE bugs emerge based on the existing code.

     

Log in to post a comment.