#4566 Vibrabomb Report Problems
As it stands, the Vibrabomb Report screen renders a sufficiently large game unplayable. Current behavior is to notify you every time that a move sets off a bomb. I was setting off a bomb about half a map away as I moved, and it would interrupt every hex I tried to move through. I stopped caring nearly immediately, but it interrupted every time, with no "don't tell me this again" option. What WAS taking me 15 seconds at most to move a mech now took in the neighborhood of 1 minute per mech. Unplayable when you're fielding 45+ mechs.
Additionally it would interrupt me and I would be unable to use sprinting movement. it would make me re-map my move EVERY interruption and it would stop when I ran out of running movement. I could not continue into sprinting movement.
Attached is a savegame where we encountered this. users are "Restless" and "Foxx"
Fixed in [9f5413].
The problem is that Server.deliverThunderVibraMinefield would add minefields to the Game's list of vibrabombs, but not to the Game's list of minefields. Game's vibrabomb list is basically a short cut to get access to just vibrabomb fields, however vibrabomb fields also must be in Game.minefields, otherwise issues happen.
What was happening here was that, once the field got detonated, it's Minefield.detonated state was set to true, however since it was never added to Game.minefields, when Server.resetMines is called, the detonated state is never reset, so then whenever anything else moves, it looks like it detonated a vibrabomb field (even thought it didn't).
I fixed this by updating Server.deliverThudnerVibraMinefield to call both Game.addMinefield and Game.addVibraBomb.
Related
Commit: [9f5413]