Menu

#4471 "Center view on unit" tries to center view on offboard units

stable 0.42
closed
None
fixed
1
2015-04-19
2015-02-23
No

By default MM will center the map on the currently selected unit, but it also tries to do this with units that are off board (such as off board artillery), which results in MM zooming to the edge of the map every time it is an off board unit's turn to fire. It shouldn't be trying to do that as there is no point (the unit is off board in the first place, so it can't center the view on it) and it just means that you have to re-center the map view on the battle area.

https://sourceforge.net/p/megamek/bugs/4469/attachment/3025.rar if you want a save file with artillery to test.

Discussion

  • Nicholas Walczak

    • assigned_to: Nicholas Walczak
    • Resolution: none --> fixed
    • Milestone: undetermined --> stable 0.42
     
  • Nicholas Walczak

    Fixed in [r11693].

    This really only effects the TargetingDisplay. MovementDisplay shouldn't be able to select offboard units. If a unit's position is null, the centering doesn't happen, however it looks like in some cases offboard units can have non-null positions, but those positions are off the board. It looks like FiringDisplay has code to prevent the centering from happening (it checks to see if the entity is off the board). Looksl ike TargetingDisplay missed those changes when FiringDisplay was updated (they end up sharing a lot of similar code).

     

    Related

    Commit: [r11693]

  • Nicholas Walczak

    • Status: open --> closed
     

Log in to post a comment.