#4257 ProtoMech BV Calculating Incorrectly
As posted here: http://bg.battletech.com/forums/index.php/topic,41348.msg965190.html#msg965190
Discrepancies between MegaMek Proto BV and MUL/Record Sheet Proto BV.
Example 1: Erinyes 2
Defensive BV
8 (total armor factor) x 2.5 = 20
+ (7 (total internal structure) x 1.5) = 30.5
total: 30.5
30.5 x [(1.3 (defensive factor of TM +3) + 0.1 (proto factor)] = 42.7
total: 42.7
Offensive BV
7 (er micro laser) x 1.37 (speed factor of running 8) = 9.59
total: 9.59
42.7 (defensive BV total) + 9.59 (offensive BV total) = 52.29, round down for 52 BV.
Example 2: Orc
Defensive BV
20 (total armor factor) x 2.5 = 50
+ (10 (total internal structure) x 1.5) = 65
total: 65
65 x [1.3 (defensive factor of TM +3) + 0.1 (proto factor)] = 91
total: 91
Offensive BV
((15 x 4 [4 SRM-1s])
+ 0.4 (200 kgs of ammo (20 SRM-1 rounds) ÷ 1000, x 2 (SRM-1 BV for 1 ton))
x 1.50 (speed factor of running 9) = 90.6
total: 90.6
91 (defensive BV total) + 90.6 (offensive BV total) = 181.6, round up to 182 BV
Diff:
I guess that Hammer fixed the issue in [r11275].
I didn't realize this, and started looking into the issue. I noticed that for the Orc 2,3 and 4 that MM is still off by one for the BVs compared to the MUL. In order to diagnose the issue, I added a detailed BV calculation report in [r11305]. Despite this report, I still don't see what exactly is causing the off-by-one errors. I guess it might be related to the speed factor.
Related
Commit: [r11275]
Commit: [r11305]
I've come to the conclusion that the MUL must be out of date. I can't find any discrepancies with the way MM computes Protomech BV, and I can't account for the off-by-one.