[Maxima-bugs] [ maxima-Bugs-658762 ] pickapart misnumbers next C-line FIX

[<no...@so...>]

Bugs item #658762, was opened at 2002-12-26 14:27
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104933&aid=658762&group_id=4933

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Stavros Macrakis (macrakis)
Assigned to: Nobody/Anonymous (nobody)
Summary: pickapart misnumbers next C-line FIX

Initial Comment:
In Maxima 5.5 Windows GCL

Pickapart usually misnumbers the C-line following its 
result.  Instead of (e.g.) E5 E6 D6 C7 D7, you get E5 E6 
D6 C6 D6, which means that the pickapart return value 
D6 is overwritten by the more recent return value.

The test case below consistently elicits this behavior in 
a fresh Maxima, or after a Kill(Labels).  So does example
(pickapart).  Sometimes when Pickapart reuses a 
preexisting label -- or perhaps under other 
circumstances -- it does not present this problem.

(C1) (x+1)*(x+2);
(D1)                     (x + 1) (x + 2)
(C2) pickapart(d1,1);

(E2)                          x + 1


(E3)                          x + 2

(D3)                          E2 E3
(C3) x^3;
                                 3
(D3)                            x
(C4) 

This can be fixed in Continue (macsys.lisp) as follows:

    (when (or (not (checklabel $inchar))
	      (not (checklabel $outchar)))  ;new 
condition
	  (setq $linenum (f1+ $linenum)))

I am tempted to change the when to a while just to be 
sure, but I don't know of any reason that would be 
necessary.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104933&aid=658762&group_id=4933