Re: [Mapbuilder-devel] Clarification on Mapbuilder bug MAP-12

[Steven M. O. <ste...@ge...>]

Right that makes sense, I applied the fix in svn,

thanks saul

Steven

Saul Farber wrote:
> Cameron,
>
> I can speak to this one, as I've fixed that specific problem before.
>
> The problem is this:
>
> Unlike the java proxy code, the port-number in the PHP code isn't read 
> from a header value.  Instead the php proxy reads the value of the "url" 
> CGI parameter and parses it into a local array called 'parsed' (which I 
> believe contains 'host','port','path' and 'query' indexes)
>
> The php proxy code then opens a connection to the parsed url, posts the 
> contents of its own POST body, if present, and returns the response.
>
> However, there's a bug in the code.  The port number of the target 
> address (the one where geoserver probably lives) isn't taken from the 
> "url" parameter, but is rather just copied blindly from the _REQUEST 
> parameter.
>
> This means that a call to:
>
>
> http://myserver/proxy.php?url=ENCODED(http://google.com:443/path?query=abc&lang=en)
>
> (where ENCODED(x) indicates that a real url in this case would have to 
> be URL endoded at this part)
>
>
> Would attempt to open a connection to google.com on port EIGHTY (since 
> the original request was on port 80) and NOT on port 443, as indicated 
> in the url= parameter.
>
> The fix is to read the target port from the correct array (parsed) 
> rather than the wrong one (_REQUEST).
>
> make sense?
>
> --saul
>
>
> Cameron Shorter wrote:
>   
>> Hi zjonp,
>> We have a bug in our Mapbuilder bug tracker which I think you added 
>> (back when we were using the sourceforge bug tracker).
>>
>> http://jira.codehaus.org/browse/MAP-12
>>
>> We are having problems understanding what the problem is and 
>> consequently, how to fix it.
>>
>> Can you remember what the problem is, and if so, could you please give 
>> us some more details to help us reproduce the problem.
>>
>>     
>
>
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> mapbuilder-devel mailing list
> map...@li...
> https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
>   


-- 
Geodan S&R Amsterdam

-------------------------------------
Geodan S&R
President Kennedylaan 1
1079 MB Amsterdam (NL)
-------------------------------------
Tel: +31 (0)20 - 5711 311
Fax: +31 (0)20 - 5711 333
-------------------------------------
E-mail: ste...@ge...
Website: www.geodan.nl
Disclaimer: www.geodan.nl/disclaimer
-------------------------------------