Thread: [Lxr-dev] [ lxr-Bugs-3466565 ] html-fatal.html errors out on non-existant sub
Brought to you by:
ajlittoz
From: SourceForge.net <no...@so...> - 2011-12-28 20:34:34
|
Bugs item #3466565, was opened at 2011-12-28 12:34 Message generated for change (Tracker Item Submitted) made by ajlittoz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3466565&group_id=27350 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Browsing Group: current cvs Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andre-Littoz (ajlittoz) Assigned to: Andre-Littoz (ajlittoz) Summary: html-fatal.html errors out on non-existant sub Initial Comment: When inlining (and removing) sub stylesheet in Template.pm, an occurrence was forgotten in makeerrorpage. For maintenance reason, since substitution variable $stylesheet is used in 3 template expanders with the same semantics, it would be wise to restore sub stylesheet to avoid future similar bugs after update. Performance impact should be very low (even beneficial?) because with inlining we create anonymous subs instead of using single named one. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3466565&group_id=27350 |
From: SourceForge.net <no...@so...> - 2011-12-30 10:45:01
|
Bugs item #3466565, was opened at 2011-12-28 12:34 Message generated for change (Comment added) made by ajlittoz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3466565&group_id=27350 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Browsing Group: current cvs >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Andre-Littoz (ajlittoz) Assigned to: Andre-Littoz (ajlittoz) Summary: html-fatal.html errors out on non-existant sub Initial Comment: When inlining (and removing) sub stylesheet in Template.pm, an occurrence was forgotten in makeerrorpage. For maintenance reason, since substitution variable $stylesheet is used in 3 template expanders with the same semantics, it would be wise to restore sub stylesheet to avoid future similar bugs after update. Performance impact should be very low (even beneficial?) because with inlining we create anonymous subs instead of using single named one. ---------------------------------------------------------------------- >Comment By: Andre-Littoz (ajlittoz) Date: 2011-12-30 02:45 Message: sub $stylesheet has been restored. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=390117&aid=3466565&group_id=27350 |