Re: [Lxde-list] Rules for XXX_INCLUDE_DIR in config.cmake files

[Александр С. <sok...@gm...>]

Ok, agreed, we will use a prefix.

There is an additional proposal. In addition to file type lxqtaboutdialog.h
we create class-name files like LxQtAboutDialog. Programmer should include
them as "<lxqt/LxQtAboutDialog>" Not very convenient mess
lowercase-uppercase.

My suggestion,
1. files are put in /usr/include/lxqt
2. additionally create a symlink /usr/include/LxQt ->  /usr/include/lxqt
3. For files LxQtAboutDialog we remove the prefix LxQt.

Programmer will include the header file so:
#include <LxQt/AboutDialog>
the directory is a namespace, filename - a name of the class.

What?


2013/10/22 PCMan <pcm...@gm...>

> On Tue, Oct 22, 2013 at 5:21 PM,  <u-...@ae...> wrote:
> >> Александр Соколов has written on Tuesday, 22 October, at 12:41:
> >> >Variant 1.
> >> >   The QTXDG_INCLUDE_DIR is equal "/usr/include". In this case in the
> code
> >> >we use "#include <qtxdg/XdgDirs>". The X11 behave so.
> >
> > Namespacing is good.
> Second that!
> Though variant 2 is easier to write and is more visually appealing,
> variant 1 seems to be safer and prevent some conflicts.
>
> >> >Variant 2.
> >> >   The QTXDG_INCLUDE_DIR is equal "/usr/include/qtxdg". In this case
> in the
> >> >code we use "#include <XdgDirs>". The Qt4 behave so.
> >
> > No namespacing is risky, think of name collisions with someone else's
> >  "XdgDirs" or something
> > which for whatever reason may happen to be desirable to include in the
> same
> > source file...
> >
> > Rune
> >
> >
> >
> ------------------------------------------------------------------------------
> > October Webinars: Code for Performance
> > Free Intel webinars can help you accelerate application performance.
> > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> > the latest Intel processors and coprocessors. See abstracts and register
> >
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Lxde-list mailing list
> > Lxd...@li...
> > https://lists.sourceforge.net/lists/listinfo/lxde-list
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
> _______________________________________________
> Lxde-list mailing list
> Lxd...@li...
> https://lists.sourceforge.net/lists/listinfo/lxde-list
>



-- 
Best regards,
Alexander.