Re: [Lxde-list] The lxpanel changes are committed

[PCMan <pcm...@gm...>]

Another new regression bug was found.
Task bar buttons didn't show button of the currently active window in
depressed state. So there is no way to tell which window is active
from taskbar.

On Thu, Jul 9, 2009 at 7:59 PM, Marty Jack<mar...@co...> wrote:
> http://forum.lxde.org/viewtopic.php?f=21&t=504
>
> The wincmd plugin is not a window manager.  The particular user was in a memory constrained environment, which LXDE is targeted for, and the mass de-iconization caused heavy swapping.  We all know that the purpose of mass iconization is to hide windows as quickly as possible when new individuals enter your environment and you have items on your display that you would prefer they not see.
>
> Apparently both Gnome and Medical-Wei disagree with you on this.  Maybe some others can offer opinions on whether I have done the right thing.
>
> PCMan wrote:
>> This, however, is the standard behaviour of window managers documented
>> in EWMH spec.
>> If it's slow, that's the problem of window manager, not lxpanel, I think.
>> Maybe this should be optional, and the default behaviour is to toggle
>> minimize state rather than to minimize all windows only.
>>
>> On Thu, Jul 9, 2009 at 7:20 PM, Marty Jack<mar...@co...> wrote:
>>> We had a request to do it this way on the forum.  I asked for feedback on the list before making this change.  The user found it inconvenient and quite slow on his machine that the restore behavior was present.  Given that we know what this feature is actually for, there should be no delay in minimizing windows when requested.
>>>
>>> PCMan wrote:
>>>> Besides, the new wincmd plugin works differently from the original one.
>>>> It only minimized all windows, but you cannot restore the windows to
>>>> their original states later. This is quite inconvenient. Is there any
>>>> good reason to make it work like this?
>>>>
>>>> Thanks
>>>>
>>>> On Thu, Jul 9, 2009 at 1:39 PM, PCMan<pcm...@gm...> wrote:
>>>>> Tested the latest lxpanel svn trunk.
>>>>> I have made some modifications to the glade file of panel preference dialog.
>>>>> Besides, I noted some issues.
>>>>> 1. The clicked effect of launchbar buttons is gone. Previously the
>>>>> buttons are depressed when they are clicked to provide visual
>>>>> feedbacks.
>>>>> 2. The new taskbar centers the title of windows on its buttons, which
>>>>> is different from the original one and this could looked weird when
>>>>> the title is quite short but the button is quite wide.
>>>>> 3. The new layout of launbar buttons is great, but there is no way to
>>>>> specify button size.
>>>>> 4. The new floating layout of items is not applied to taskbar buttons.
>>>>> 5. How could we merge the translated strings in lxpanel-plugins back
>>>>> to lxpanel trunk, and remove duplicated plugins? Any translators here
>>>>> know how to do it correctly?
>>>>> 6. The taskbar item has no title when window grouping is enabled.
>>>>> Maybe we can show program name for it?
>>>>> 7. The new launchbar config dialog is very cool! Nice work!
>>>>>
>>>>> Thanks for all your great work!
>>>>>
>>>>> On Thu, Jul 9, 2009 at 5:48 AM, Marty Jack<mar...@co...> wrote:
>>>>>> There is no good reason to use different memory allocation API in different parts of the code.  The memory usage is not demanding enough to require special treatment.  There is too much risk of allocating with one API and freeing with another.  The slice calls were only used in one or two places.
>>>>>>
>>>>>> You don't mention how much too high it is.  I was, actually, more worried that the new launchbar dialog was too wide.  Who has access to the machine you would want to get it working nicely with, and can they rework the glade file.  It looks like moving Margin up underneath the other column would help a lot.
>>>>>>
>>>>>> PCMan wrote:
>>>>>>> Some initial comments:
>>>>>>> I've not tested the latest source code yet. Will do it later as soon
>>>>>>> as I go home.
>>>>>>> After a breif review of the code, here are some questions:
>>>>>>> 1. is there any good reason to replace g_slice_new0 with g_new0?
>>>>>>>   Since we already require higher version of gtk+/glib, g_slice API
>>>>>>> should be available.
>>>>>>> 2. the new configuration dialog is too high to be fit in small screens
>>>>>>> on some netbooks such as EeePC 701. Some widgets in the first page
>>>>>>> might have been moved to another page or there could be a separate
>>>>>>> glade file for small screens.
>>>>>>>
>>>>>>> Otherwise your work is quite awesome and is highly-appreciated!
>>>>>>>
>>>>>>> On Thu, Jul 9, 2009 at 3:49 AM, Marty Jack<mar...@co...> wrote:
>>>>>>>> It identifies itself as 0.4.990.  I consider it in code freeze and string freeze.  Refer to the release notes I posted before on the mailing list and the forum for a description of the functional changes.
>>>>>>>>
>>>>>>>> If there is a disaster and you have to go backward, remember that the old release does not handle unrecognized parameter names.  There is one new parameter in the taskbar plugin to handle task grouping.  You would have to edit that out of the panel configuration in .config/lxpanel/panels in order to get your panels to start under the old release.  Remember not to leave an editor backup file around.  The old release will try to load it a second time and overlay your panel.  That is another little thing that I've fixed.
>>>>>>>>
>>>>>>>> Please advise if you have any comment whatever, positive or negative, or if you find a bug.
>>>>>>>>
>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>> Enter the BlackBerry Developer Challenge
>>>>>>>> This is your chance to win up to $100,000 in prizes! For a limited time,
>>>>>>>> vendors submitting new applications to BlackBerry App World(TM) will have
>>>>>>>> the opportunity to enter the BlackBerry Developer Challenge. See full prize
>>>>>>>> details at: http://p.sf.net/sfu/Challenge
>>>>>>>> _______________________________________________
>>>>>>>> Lxde-list mailing list
>>>>>>>> Lxd...@li...
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/lxde-list
>>>>>>>>
>>
>