From: Gurjot S. <bha...@gm...> - 2014-01-16 14:16:06
|
Hi, @UI development team The following is the screenshot of the latest build of the stable-0.4 branch code. http://postimg.org/image/ki30a5g77/ 1.)As you can see that it is quite difficult to read the names of tracks in both Song-Editor area as well as Beat+Bassline Editor. 2.)You can't really see the slot names A,B,C,D in the FX mixer. 3.)Difficult to read the tabs name (cutoff,reso, etc.) in the Instrument (Preset) Settings area. -- Gurjot Singh Blog: http://bhattigurjot.wordpress.com |
From: Jonathan A. <eag...@gm...> - 2014-01-16 14:30:55
|
Gurjot, would you mind submitting a bug in the issue tracker in github please. On Thursday 16 January 2014 19:45:59 Gurjot Singh wrote: > Hi, > @UI development team > > The following is the screenshot of the latest build of the stable-0.4 > branch code. > http://postimg.org/image/ki30a5g77/ > > 1.)As you can see that it is quite difficult to read the names of > tracks in both Song-Editor area as well as Beat+Bassline Editor. > 2.)You can't really see the slot names A,B,C,D in the FX mixer. > 3.)Difficult to read the tabs name (cutoff,reso, etc.) in the > Instrument (Preset) Settings area. |
From: Vesa <di...@nb...> - 2014-01-16 14:31:26
|
On 01/16/2014 04:15 PM, Gurjot Singh wrote: > Hi, > @UI development team > > The following is the screenshot of the latest build of the stable-0.4 > branch code. > http://postimg.org/image/ki30a5g77/ > > 1.)As you can see that it is quite difficult to read the names of > tracks in both Song-Editor area as well as Beat+Bassline Editor. > 2.)You can't really see the slot names A,B,C,D in the FX mixer. > 3.)Difficult to read the tabs name (cutoff,reso, etc.) in the > Instrument (Preset) Settings area. > That... is not how the UI is supposed to look at the moment. That is a glitch. (you didn't seriously think we were making everything white, did you?) I'll even tell you what causes it. It's because you still have the old theme selected in your settings. Go to your settings, to the folder tab, and point the "artwork" to the directory of the new LMMS directory's default theme instead of the 0.4.15 default theme. It's caused by the change where palette information is read from the stylesheet, but if the stylesheet doesn't have the palette information, everything goes white. I've already made a change to solve this, namely, making it so that hardcoded defaults are used if palette information isn't found in the stylesheet, but I haven't yet committed this change (and it may be hard for me to commit anything until the cmake glitch is fixed so that I can build again). |
From: Gurjot S. <bha...@gm...> - 2014-01-16 14:39:48
|
On 16 January 2014 20:01, Vesa <di...@nb...> wrote: > That... is not how the UI is supposed to look at the moment. That is a > glitch. (you didn't seriously think we were making everything white, did > you?) Ok. I was just confirming. That's why I didn't file an issue for this. > I'll even tell you what causes it. It's because you still have the old > theme selected in your settings. Go to your settings, to the folder tab, > and point the "artwork" to the directory of the new LMMS directory's > default theme instead of the 0.4.15 default theme. WOW! The new look does look awesome. Keep up the good work. :) > It's caused by the change where palette information is read from the > stylesheet, but if the stylesheet doesn't have the palette information, > everything goes white. I've already made a change to solve this, > namely, making it so that hardcoded defaults are used if palette > information isn't found in the stylesheet, but I haven't yet committed > this change (and it may be hard for me to commit anything until the > cmake glitch is fixed so that I can build again). You were asking about the xml input for color coding. What's the status on that? Is it gonna be used or not? -- Gurjot Singh Blog: http://bhattigurjot.wordpress.com |
From: Vesa <di...@nb...> - 2014-01-16 14:44:28
|
On 01/16/2014 04:39 PM, Gurjot Singh wrote: > WOW! The new look does look awesome. Keep up the good work. :) Thanks, we will :) > > You were asking about the xml input for color coding. What's the > status on that? Is it gonna be used or not? > The status is that instead of using xml, there's now a section in the style.css where the palette values are defined. The values are read from it using regexp and string manipulation, so it's nothing fancy really. Old themes (including the 0.4.15 default theme) obviously don't have this section, which is now causing weird behaviour. |
From: Gurjot S. <bha...@gm...> - 2014-01-16 14:51:44
|
On 16 January 2014 20:14, Vesa <di...@nb...> wrote: > The status is that instead of using xml, there's now a section in the > style.css where the palette values are defined. The values are read from > it using regexp and string manipulation, so it's nothing fancy really. > Old themes (including the 0.4.15 default theme) obviously don't have > this section, which is now causing weird behaviour. Ok that explains the color problem. It would be really nice to have the user define his own theme one day, but that's the task for the future. -- Gurjot Singh Blog: http://bhattigurjot.wordpress.com |
From: Vesa <di...@nb...> - 2014-01-16 14:53:23
|
On 01/16/2014 04:51 PM, Gurjot Singh wrote: > On 16 January 2014 20:14, Vesa <di...@nb...> wrote: >> The status is that instead of using xml, there's now a section in the >> style.css where the palette values are defined. The values are read from >> it using regexp and string manipulation, so it's nothing fancy really. >> Old themes (including the 0.4.15 default theme) obviously don't have >> this section, which is now causing weird behaviour. > Ok that explains the color problem. > It would be really nice to have the user define his own theme one day, > but that's the task for the future. > > Well, it's already possible. If the user knows CSS that is. There are already some user-made themes available. |
From: Gurjot S. <bha...@gm...> - 2014-01-16 14:57:09
|
On 16 January 2014 20:23, Vesa <di...@nb...> wrote: > Well, it's already possible. If the user knows CSS that is. There are > already some user-made themes available. Yes that's one possibility. But I was talking about the GUI tool/option to change the color, theme options something like Blender does. Where this option is in-built for the user to make such changes as in User Preferences. -- Gurjot Singh Blog: http://bhattigurjot.wordpress.com |
From: Jonathan A. <eag...@gm...> - 2014-01-16 14:54:51
|
Vesa how hard would it be to make a GUI like front end that will allow someone who doesnt know css to make modifications to the look and theme of their lmms install? On Thursday 16 January 2014 16:53:15 Vesa wrote: > On 01/16/2014 04:51 PM, Gurjot Singh wrote: > > On 16 January 2014 20:14, Vesa <di...@nb...> wrote: > >> The status is that instead of using xml, there's now a section in the > >> style.css where the palette values are defined. The values are read from > >> it using regexp and string manipulation, so it's nothing fancy really. > >> Old themes (including the 0.4.15 default theme) obviously don't have > >> this section, which is now causing weird behaviour. > > > > Ok that explains the color problem. > > It would be really nice to have the user define his own theme one day, > > but that's the task for the future. > > Well, it's already possible. If the user knows CSS that is. There are > already some user-made themes available. > > ---------------------------------------------------------------------------- > -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > LMMS-devel mailing list > LMM...@li... > https://lists.sourceforge.net/lists/listinfo/lmms-devel |
From: Vesa <di...@nb...> - 2014-01-16 15:04:23
|
On 01/16/2014 04:54 PM, Jonathan Aquilina wrote: > Vesa how hard would it be to make a GUI like front end that will allow someone > who doesnt know css to make modifications to the look and theme of their lmms > install? > Well, it largely depends on how much modifications the users should be able to make. If it's only modifications to the basic palette (the one that is now being read from the .css file), it wouldn't be hard as such, but would still require an entirely separate mechanism on top of the theming system - because the modified palette would need to be stored somewhere other than the theme. But this has the problem that the palette only affects a limited portion of the colours - a lot of the UI element colours are defined in the CSS instead of the palette. If it's modifications to the css elements and styles as well, then that'd be extremely hard and lots of work. Frankly, it wouldn't be much use, since the user would still be required to understand the CSS elements and properties and what they do, and if the user understands those, they can just edit the css file directly... |
From: Jonathan A. <eag...@gm...> - 2014-01-16 15:06:00
|
I would start off small, we can always grow the functionality of what can be customized as time progresses On Thursday 16 January 2014 17:04:01 you wrote: > On 01/16/2014 04:54 PM, Jonathan Aquilina wrote: > > Vesa how hard would it be to make a GUI like front end that will allow > > someone who doesnt know css to make modifications to the look and theme > > of their lmms install? > > Well, it largely depends on how much modifications the users should be > able to make. If it's only modifications to the basic palette (the one > that is now being read from the .css file), it wouldn't be hard as such, > but would still require an entirely separate mechanism on top of the > theming system - because the modified palette would need to be stored > somewhere other than the theme. But this has the problem that the > palette only affects a limited portion of the colours - a lot of the UI > element colours are defined in the CSS instead of the palette. > > If it's modifications to the css elements and styles as well, then > that'd be extremely hard and lots of work. Frankly, it wouldn't be much > use, since the user would still be required to understand the CSS > elements and properties and what they do, and if the user understands > those, they can just edit the css file directly... |
From: Vesa <di...@nb...> - 2014-01-16 15:11:47
|
On 01/16/2014 05:05 PM, Jonathan Aquilina wrote: > I would start off small, we can always grow the functionality of what can be > customized as time progresses Well the thing is, at the moment I don't see much use for this kind of functionality - it's likely to only confuse the user and flood us with bug reports ("I try to change the colour x but it only affects y and not z")... We would need to rework all of the custom widgets to be CSS-stylable, so that everything comes from the CSS instead of the palette... and as of now I have no idea how to do that. The current solution is kind of hackish, in that part of the widgets are CSS-styleable, and the others can be modified in a limited way by changing the palette, but at least it gives themers the opportunity to create a bit more complete themes. Complete CSS-stylability is probably something that will be implemented down the line, in the future - and at that point, we can start thinking again if we can implement something like this. But right now we're just focusing on making the UI look and feel presentable and modern. |
From: Tres F. <tre...@gm...> - 2014-01-16 15:24:12
|
I'm probably the only one with this opinion, but the default gray as a second option is very attractive to me. It also forces the concept of dark vs. light text (which can be reasonably easily detected using lumen calculation) . In addition, it would allow quick transparency testing on the PNGs, since sometimes dark or light artifacts get overlooked. Just my 2c, since I'm not offering to do an extensive amount of CSS work at this time. -Tres - Tre...@gm... On Thu, Jan 16, 2014 at 10:11 AM, Vesa <di...@nb...> wrote: > On 01/16/2014 05:05 PM, Jonathan Aquilina wrote: > > I would start off small, we can always grow the functionality of what > can be > > customized as time progresses > > Well the thing is, at the moment I don't see much use for this kind of > functionality - it's likely to only confuse the user and flood us with > bug reports ("I try to change the colour x but it only affects y and not > z")... > > We would need to rework all of the custom widgets to be CSS-stylable, so > that everything comes from the CSS instead of the palette... and as of > now I have no idea how to do that. The current solution is kind of > hackish, in that part of the widgets are CSS-styleable, and the others > can be modified in a limited way by changing the palette, but at least > it gives themers the opportunity to create a bit more complete themes. > > Complete CSS-stylability is probably something that will be implemented > down the line, in the future - and at that point, we can start thinking > again if we can implement something like this. But right now we're just > focusing on making the UI look and feel presentable and modern. > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > LMMS-devel mailing list > LMM...@li... > https://lists.sourceforge.net/lists/listinfo/lmms-devel > |