From: Sami B. <sam...@gm...> - 2010-05-24 07:57:45
Attachments:
save_before_closing.patch
|
Hello, I have made a patch for the “Save changes?” dialog box to let the user choose between “Save”, “Discard” and “Cancel” instead of “Yes”, “No” and “Cancel”. I find this way more intuitive, since it enables Qt to reorganize the buttons properly according to the platform and to give them an icon (at least on X11). It also allows users to know what is going to happen without having to read the question. Thank you and sorry for my english, it is not my native language. |
From: Andrew R K. <and...@gm...> - 2010-05-25 01:00:08
|
I've integrated your patch, thanks! On Mon, May 24, 2010 at 12:57 AM, Sami BOUKORTT <sam...@gm...>wrote: > Hello, > > I have made a patch for the “Save changes?” dialog box to let the user > choose > between “Save”, “Discard” and “Cancel” instead of “Yes”, “No” and “Cancel”. > > I find this way more intuitive, since it enables Qt to reorganize the > buttons > properly according to the platform and to give them an icon (at least on > X11). > > It also allows users to know what is going to happen without having to read > the question. > > Thank you and sorry for my english, it is not my native language. > > > ------------------------------------------------------------------------------ > > > _______________________________________________ > LMMS-devel mailing list > LMM...@li... > https://lists.sourceforge.net/lists/listinfo/lmms-devel > > -- Andy Kelley http://superjoesoftware.com/ |
From: Tobias D. <tob...@gm...> - 2010-05-25 06:59:45
|
Hi, Am Dienstag, 25. Mai 2010, um 03:00:02 schrieb Andrew R Kelley: > I've integrated your patch, thanks! Thanks! Next time please give the author credit in the commit message :-) Toby |
From: Andrew R K. <and...@gm...> - 2010-05-25 09:53:34
|
I did! Here's the log: Save/Discard instead of Yes/No Integrates Sami Boukortt's patch described below: I have made a patch for the “Save changes?” dialog box to let the user choos between “Save”, “Discard” and “Cancel” instead of “Yes”, “No” and “Cancel”. I find this way more intuitive, since it enables Qt to reorganize the button properly according to the platform and to give them an icon (at least on X11 It also allows users to know what is going to happen without having to read the question. On Mon, May 24, 2010 at 11:59 PM, Tobias Doerffel <tob...@gm... > wrote: > Hi, > > Am Dienstag, 25. Mai 2010, um 03:00:02 schrieb Andrew R Kelley: > > I've integrated your patch, thanks! > Thanks! Next time please give the author credit in the commit message :-) > > Toby > -- Andy Kelley http://superjoesoftware.com/ |
From: Tobias D. <tob...@gm...> - 2010-05-25 10:41:54
|
Oh I'm sorry.. I was in a hurry when reading the logs.. you're right :-) Toby |
From: Andrew R K. <and...@gm...> - 2010-05-25 10:42:36
|
No problem. I noticed you've been working on LMMS lately :) On Tue, May 25, 2010 at 3:41 AM, Tobias Doerffel <tob...@gm...>wrote: > Oh I'm sorry.. I was in a hurry when reading the logs.. you're right :-) > > Toby > -- Andy Kelley http://superjoesoftware.com/ |